Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 820343002: disable using codecs until that can work in chrome (Closed)

Created:
5 years, 12 months ago by reed2
Modified:
5 years, 11 months ago
Reviewers:
scroggo, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

disable using codecs until that can work in chrome BUG=skia:3275 TBR= Committed: https://skia.googlesource.com/skia/+/2906d4a387ad566cf26bf262278895085e03b7ba

Patch Set 1 #

Patch Set 2 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M gm/cgm.c View 1 chunk +4 lines, -2 lines 1 comment Download
M src/c/sk_surface.cpp View 1 chunk +5 lines, -2 lines 2 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820343002/1
5 years, 12 months ago (2014-12-26 04:24:19 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/1688)
5 years, 12 months ago (2014-12-26 04:28:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820343002/20001
5 years, 12 months ago (2014-12-26 04:32:18 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/2906d4a387ad566cf26bf262278895085e03b7ba
5 years, 12 months ago (2014-12-26 04:41:17 UTC) #7
scroggo
https://codereview.chromium.org/820343002/diff/20001/gm/cgm.c File gm/cgm.c (right): https://codereview.chromium.org/820343002/diff/20001/gm/cgm.c#newcode70 gm/cgm.c:70: if (img1) { Can we at least log something ...
5 years, 11 months ago (2014-12-30 11:14:33 UTC) #9
reed1
5 years, 11 months ago (2015-01-05 16:04:59 UTC) #11
Message was sent while issue was closed. 
https://codereview.chromium.org/820343002/diff/20001/src/c/sk_surface.cpp
File src/c/sk_surface.cpp (right):

https://codereview.chromium.org/820343002/diff/20001/src/c/sk_surface.cpp#new...
src/c/sk_surface.cpp:237: #if 0
On 2014/12/30 11:14:33, scroggo wrote:
> Can we use a macro here to only behave this way if we're in Chrome, or more
> specifically if we do not have SkDecodingImageGenerator?
> 
> (We could use that same macro in cgm.c, which would cover my concerns there.)

The #if 0 is meant to be (very) temporary, as I hope to enable codecs in chrome
asap.

Powered by Google App Engine
This is Rietveld 408576698