content/renderer/render_view_impl.cc - Issue 82033002: Always create FrameTreeNodes and RenderFrameHosts for every frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 82033002: Always create FrameTreeNodes and RenderFrameHosts for every frame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix two bugs with slow/crashed renderers; add tests Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index b21d9e047b9a4e914326cd43acb012f2db1e9439..fe683d5f99680b4e204cbda0445d74b7464f8de6 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -3167,6 +3167,10 @@ void RenderViewImpl::didDisownOpener(blink::WebFrame* frame) {

}

void RenderViewImpl::frameDetached(WebFrame* frame) {

+ // NOTE: We may get here for either the main frame or for subframes. The

+ // RenderFrameImpl will be deleted immediately after this call for subframes

+ // but not for the main frame, which is kept around in a scoped_ptr.

FOR_EACH_OBSERVER(RenderViewObserver, observers_, FrameDetached(frame));

}