Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1145)

Unified Diff: content/renderer/render_view_impl.h

Issue 82033002: Always create FrameTreeNodes and RenderFrameHosts for every frame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Initial patch Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.h
diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h
index 5f3e8912048421134259e0f6d3ef01ee53707e49..e8b0edafefd709cecab5bd47de26a62c18dada31 100644
--- a/content/renderer/render_view_impl.h
+++ b/content/renderer/render_view_impl.h
@@ -1381,7 +1381,8 @@ class CONTENT_EXPORT RenderViewImpl
// Helper objects ------------------------------------------------------------
- scoped_ptr<RenderFrameImpl> main_render_frame_;
+ // Deleted by RenderFrameImpl::frameDetach().
+ RenderFrameImpl* main_render_frame_;
awong 2013/11/22 01:07:15 I think this still needs to be a scoped_ptr. See
Charlie Reis 2013/11/22 02:07:23 I'm confused. Are you referring to this comment?
RendererWebCookieJarImpl cookie_jar_;

Powered by Google App Engine
This is Rietveld 408576698