Use absolute path instead of relative path in install-build-deps-android.sh.

Use absolute path instead of relative path in install-build-deps-android.sh.

BUG=350151
Committed: https://crrev.com/654f395d614d7fac021d2009a02f9a6d42ce0f09
Cr-Commit-Position: refs/heads/master@{#312299}

[navabi, 2015-01-13 21:51:29]

navabi@google.com changed reviewers:
+ friedman@chromium.org, pschmidt@google.com

[pschmidt1, 2015-01-13 22:24:04]

pschmidt@chromium.org changed reviewers:
+ pschmidt@chromium.org

[pschmidt1, 2015-01-13 22:24:05]

This LGTM

However we currently don't checkout android_tools as part of the slave setup. 
I'll fix that up at our end.

[navabi, 2015-01-13 22:35:04]

On 2015/01/13 22:24:05, pschmidt1 wrote:
> This LGTM
> 
> However we currently don't checkout android_tools as part of the slave setup. 
> I'll fix that up at our end.

Oh I see. That is because the android_tools checkout mentioned in the DEPS file
is under if OS=android. If you have a a chromium.gyp_env with:{ 'GYP_DEFINES':
'OS=android use_goma=1', }, then it will check out android_tools.

[pschmidt1, 2015-01-13 22:35:25]

On 2015/01/13 at 22:24:05, pschmidt1 wrote:
> This LGTM
> 
> However we currently don't checkout android_tools as part of the slave setup. 
I'll fix that up at our end.

Actually do we have to check this stuff out?  It's huge!

[navabi, 2015-01-13 23:44:57]

On 2015/01/13 22:35:25, pschmidt1 wrote:
> On 2015/01/13 at 22:24:05, pschmidt1 wrote:
> > This LGTM
> > 
> > However we currently don't checkout android_tools as part of the slave
setup. 
> I'll fix that up at our end.
> 
> Actually do we have to check this stuff out?  It's huge!

I think we need to run install-build-deps-android.sh for the Java packages, but
perhaps I can add a argument to that script to skip the SDK stuff. That part of
the script is not needed, because there is another mechanism on the bots to
download those packages.

Another strategy is to move the java and other stuff into install-build-deps.sh
and leave only the SDK stuff in install-build-deps-android.sh. Let me know if
you have a preference. Otherwise, I'll decide. Either way, I'm landing this.

[navabi, 2015-01-13 23:45:00]

The CQ bit was checked by navabi@google.com

[commit-bot: I haz the power, 2015-01-13 23:45:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/820173006/1

[commit-bot: I haz the power, 2015-01-13 23:45:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-13 23:45:25]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[pschmidt1, 2015-01-14 00:03:26]

On 2015/01/13 at 23:44:57, navabi wrote:
> On 2015/01/13 22:35:25, pschmidt1 wrote:
> > On 2015/01/13 at 22:24:05, pschmidt1 wrote:
> > > This LGTM
> > > 
> > > However we currently don't checkout android_tools as part of the slave
setup. 
> > I'll fix that up at our end.
> > 
> > Actually do we have to check this stuff out?  It's huge!
> 
> I think we need to run install-build-deps-android.sh for the Java packages,
but perhaps I can add a argument to that script to skip the SDK stuff. That part
of the script is not needed, because there is another mechanism on the bots to
download those packages.
> 
> Another strategy is to move the java and other stuff into
install-build-deps.sh and leave only the SDK stuff in
install-build-deps-android.sh. Let me know if you have a preference. Otherwise,
I'll decide. Either way, I'm landing this.

You can decide.   But I think your first idea of adding an argument sgtm.

[navabi, 2015-01-14 23:04:37]

PTAL. Now it will only install SDK packages with --sdk-packages. Thus, the sys
admins can just run install-build-deps-android.sh and it won't install the sdk
packages. The bots have a way to download it, so sys admins don't need to worry
about it.

[navabi, 2015-01-16 23:00:34]

Friendly ping.

[pschmidt1, 2015-01-16 23:52:25]

On 2015/01/16 at 23:00:34, navabi wrote:
> Friendly ping.

Don't you want the script to install the sdk's by default?   Otherwise you have
to communicate this flag to the developers.

It would be easy for our setup script to pass something like something
--no-sdk-packages

[navabi, 2015-01-20 01:13:55]

On 2015/01/16 23:52:25, pschmidt1 wrote:
> On 2015/01/16 at 23:00:34, navabi wrote:
> > Friendly ping.
> 
> Don't you want the script to install the sdk's by default?   Otherwise you
have
> to communicate this flag to the developers.
> 
> It would be easy for our setup script to pass something like something
> --no-sdk-packages

Good suggestion Peter. I made it --skip-sdk-packages. PTAL.

[pschmidt1, 2015-01-20 17:17:57]

On 2015/01/20 at 01:13:55, navabi wrote:
> On 2015/01/16 23:52:25, pschmidt1 wrote:
> > On 2015/01/16 at 23:00:34, navabi wrote:
> > > Friendly ping.
> > 
> > Don't you want the script to install the sdk's by default?   Otherwise you
have
> > to communicate this flag to the developers.
> > 
> > It would be easy for our setup script to pass something like something
> > --no-sdk-packages
> 
> Good suggestion Peter. I made it --skip-sdk-packages. PTAL.

LGTM

[navabi, 2015-01-20 17:25:33]

The CQ bit was checked by navabi@google.com

[commit-bot: I haz the power, 2015-01-20 17:26:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/820173006/40001

[commit-bot: I haz the power, 2015-01-20 17:26:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-20 17:26:53]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[navabi, 2015-01-20 19:31:14]

navabi@google.com changed reviewers:
+ cjhopman@chromium.org, jochen@chromium.org, scottmg@chromium.org,
thakis@chromium.org

[navabi, 2015-01-20 19:31:15]

Adding all OWNERS for review.

[cjhopman, 2015-01-20 21:07:01]

lgtm

https://codereview.chromium.org/820173006/diff/40001/build/install-build-deps...
File build/install-build-deps-android.sh (right):

https://codereview.chromium.org/820173006/diff/40001/build/install-build-deps...
build/install-build-deps-android.sh:98: packages="$(python -c
'execfile("./get_sdk_extras_packages.py")')"
Maybe comment here why we need to use the absolute path

[navabi, 2015-01-20 22:20:58]

https://codereview.chromium.org/820173006/diff/40001/build/install-build-deps...
File build/install-build-deps-android.sh (right):

https://codereview.chromium.org/820173006/diff/40001/build/install-build-deps...
build/install-build-deps-android.sh:98: packages="$(python -c
'execfile("./get_sdk_extras_packages.py")')"
On 2015/01/20 21:07:01, cjhopman wrote:
> Maybe comment here why we need to use the absolute path

Done.

[navabi, 2015-01-20 22:21:02]

The CQ bit was checked by navabi@google.com

[commit-bot: I haz the power, 2015-01-20 22:23:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/820173006/60001

[commit-bot: I haz the power, 2015-01-20 23:43:34]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-20 23:44:37]

Patchset 4 (id:??) landed as
https://crrev.com/654f395d614d7fac021d2009a02f9a6d42ce0f09
Cr-Commit-Position: refs/heads/master@{#312299}