Chromium Code Reviews
DescriptionRevert of Get all font unittests running with DirectWrite on Windows 7+ (patchset #11 id:220001 of https://codereview.chromium.org/844083002/)
Reason for revert:
breaks PlatformFontWinTest.DeriveFontWithHeight on xp and vista
Original issue's description:
> Get all font unittests running with DirectWrite on Windows 7+
>
> Fixes as per below:-
> 1. Remove the addition of the fLeading value when calculating the height for the font
> with DirectWrite. fAscent + fDescent is the height of the font and adding the fLeading
> value to it returns the spacing between lines which is not what we are looking for.
>
> 2. The FontListTest.Fonts_GetHeight_GetBaseline unittest has a condition which basically validates
> whether the difference between the font height and the baseline is different for Arial and Symbol
> fonts. This fails for DirectWrite and fails for GDI with font sizes like 50, etc. Replaced this check
> with a check for the font heights are different.
>
> 3. Reworked the PlatformFontWinTest.DeriveFontWithHeight test to ensure it passes for DirectWrite and GDI.
>
> BUG=442010
> R=msw
>
> Committed: https://crrev.com/58063de6b256e760e838af217bbc992b64f1cb59
> Cr-Commit-Position: refs/heads/master@{#311178}
TBR=msw@chromium.org,asvitkine@chromium.org,ananta@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=442010
Committed: https://crrev.com/e34da193dd4c80adf30c63cdb5ed634876240291
Cr-Commit-Position: refs/heads/master@{#311242}
Patch Set 1 #
Created: 5 years, 11 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||