Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 820173005: Revert of Get all font unittests running with DirectWrite on Windows 7+ (Closed)

Created:
5 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 11 months ago
CC:
chromium-reviews, Alexei Svitkine (slow), Daniel Erat, ckocagil
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Get all font unittests running with DirectWrite on Windows 7+ (patchset #11 id:220001 of https://codereview.chromium.org/844083002/) Reason for revert: breaks PlatformFontWinTest.DeriveFontWithHeight on xp and vista Original issue's description: > Get all font unittests running with DirectWrite on Windows 7+ > > Fixes as per below:- > 1. Remove the addition of the fLeading value when calculating the height for the font > with DirectWrite. fAscent + fDescent is the height of the font and adding the fLeading > value to it returns the spacing between lines which is not what we are looking for. > > 2. The FontListTest.Fonts_GetHeight_GetBaseline unittest has a condition which basically validates > whether the difference between the font height and the baseline is different for Arial and Symbol > fonts. This fails for DirectWrite and fails for GDI with font sizes like 50, etc. Replaced this check > with a check for the font heights are different. > > 3. Reworked the PlatformFontWinTest.DeriveFontWithHeight test to ensure it passes for DirectWrite and GDI. > > BUG=442010 > R=msw > > Committed: https://crrev.com/58063de6b256e760e838af217bbc992b64f1cb59 > Cr-Commit-Position: refs/heads/master@{#311178} TBR=msw@chromium.org,asvitkine@chromium.org,ananta@chromium.org NOTREECHECKS=true NOTRY=true BUG=442010 Committed: https://crrev.com/e34da193dd4c80adf30c63cdb5ed634876240291 Cr-Commit-Position: refs/heads/master@{#311242}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -33 lines) Patch
M ui/gfx/font_list_unittest.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M ui/gfx/platform_font_win.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gfx/platform_font_win.cc View 4 chunks +44 lines, -20 lines 0 comments Download
M ui/gfx/platform_font_win_unittest.cc View 2 chunks +49 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Get all font unittests running with DirectWrite on Windows 7+
5 years, 11 months ago (2015-01-13 09:18:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820173005/1
5 years, 11 months ago (2015-01-13 09:18:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-13 09:20:11 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 09:22:08 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e34da193dd4c80adf30c63cdb5ed634876240291
Cr-Commit-Position: refs/heads/master@{#311242}

Powered by Google App Engine
This is Rietveld 408576698