Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issue 820133003: Implement OnLegacySessionError() in CdmAdapter. (Closed)

Created:
5 years, 11 months ago by xhwang
Modified:
5 years, 11 months ago
Reviewers:
jrummell, xhwang1, ddorwin
CC:
chromium-reviews, feature-media-reviews_chromium.org, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, eme-reviews_chromium.org, teravest+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, ihf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement OnLegacySessionError() in CdmAdapter. This is the same as OnSessionError() in CDM_6 implementation. It's needed to properly support prefixed EME API. Also roll src/media/cdm/ppapi/api 09203a7:4aca594 (svn 293431:293568) Summary of changes available at: https://chromium.googlesource.com/chromium/cdm/+log/09203a7..4aca594 BUG=428384 Committed: https://crrev.com/902ff561fa17e181811392a222b0ecf0c8d53cdc Cr-Commit-Position: refs/heads/master@{#310636}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M media/cdm/ppapi/cdm_adapter.h View 1 chunk +6 lines, -0 lines 0 comments Download
M media/cdm/ppapi/cdm_adapter.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
xhwang
This CL is based on jrummell's CL: https://codereview.chromium.org/811923002/ PTAL
5 years, 11 months ago (2015-01-08 06:18:24 UTC) #2
ddorwin
LGTM. Thanks!
5 years, 11 months ago (2015-01-08 17:21:33 UTC) #3
jrummell
Other than the typo, lgtm. https://codereview.chromium.org/820133003/diff/1/media/cdm/ppapi/cdm_adapter.cc File media/cdm/ppapi/cdm_adapter.cc (right): https://codereview.chromium.org/820133003/diff/1/media/cdm/ppapi/cdm_adapter.cc#newcode822 media/cdm/ppapi/cdm_adapter.cc:822: OnSessionEror(session_id, session_id_size, error, system_code, ...
5 years, 11 months ago (2015-01-08 17:46:04 UTC) #4
xhwang
comments addressed
5 years, 11 months ago (2015-01-08 17:49:23 UTC) #5
xhwang1
https://codereview.chromium.org/820133003/diff/1/media/cdm/ppapi/cdm_adapter.cc File media/cdm/ppapi/cdm_adapter.cc (right): https://codereview.chromium.org/820133003/diff/1/media/cdm/ppapi/cdm_adapter.cc#newcode822 media/cdm/ppapi/cdm_adapter.cc:822: OnSessionEror(session_id, session_id_size, error, system_code, error_message, On 2015/01/08 17:46:03, jrummell ...
5 years, 11 months ago (2015-01-08 17:49:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820133003/20001
5 years, 11 months ago (2015-01-08 22:38:54 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-09 00:11:42 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 00:13:08 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/902ff561fa17e181811392a222b0ecf0c8d53cdc
Cr-Commit-Position: refs/heads/master@{#310636}

Powered by Google App Engine
This is Rietveld 408576698