tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 6a2c26fcc6bed77f1899a56205c5cbe18f40233b..f6fd057170690fa449f76508669e416f15f73269 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -45088,6 +45088,11 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   <int value="282" label="Force Google SafeSearch"/>
   <int value="283" label="Force YouTube Safety Mode"/>
   <int value="284" label="Allow device shutdown"/>
+  <int value="285" label="RemoteAccessHostMatchUsername"/>
+  <int value="286" label="RemoteAccessHostTokenUrl"/>
+  <int value="287" label="RemoteAccessHostTokenValidationUrl"/>
+  <int value="288" label="RemoteAccessHostTokenValidationCertificateIssuer"/>
+  <int value="289" label="RemoteAccessHostDebugOverridePolicies"/>

[jar (doing other things), 2015/01/07 18:13:56]

Question (which I had trouble tracking down): What kind of histogram is
recording this?  Is this recorded in Chromium? If you are already using a SPARSE
histogram... then great.... but if not...

This enum value is getting large... so perhaps this is part of a
UMA_HISTOGRAM_ENUMERATION.... and perhaps it is also sparse (for a single user?)
and *might* benefit (data space usage) to use a sparse histogram.

289 buckets in a histogram is not "the end of the world," but it is getting
larger than the common 50-100p

[Łukasz Anforowicz, 2015/01/07 18:25:45]

I am sorry, but I am not able to answer the questions above.  The reason why I
am modifying histograms.xml is that after changing policy_templates.json, I was
getting errors from "git cl presubmit" that were asking me to add the new policy
entries to histograms.xml as well: 

$ git cl presubmit
...
Running presubmit commit checks ...
...
** Presubmit ERRORS **
...
Policy 'RemoteAccessHostMatchUsername' was added to policy_templates.json but
not to src/tools/metrics/histograms/histograms.xml. Please update both files.

Policy 'RemoteAccessHostTokenUrl' was added to policy_templates.json but not to
src/tools/metrics/histograms/histograms.xml. Please update both files.

Policy 'RemoteAccessHostTokenValidationUrl' was added to policy_templates.json
but not to src/tools/metrics/histograms/histograms.xml. Please update both
files.

Policy 'RemoteAccessHostTokenValidationCertificateIssuer' was added to
policy_templates.json but not to src/tools/metrics/histograms/histograms.xml.
Please update both files.

Policy 'RemoteAccessHostDebugOverridePolicies' was added to
policy_templates.json but not to src/tools/metrics/histograms/histograms.xml.
Please update both files.


Does that help?

[Alexei Svitkine (slow), 2015/01/07 18:39:39]

The two histograms that log this enum (Enterprise.Policies and
EnterpriseCheck.InvalidPolicies) are already logged using the sparse macro, so
it's already all good.

 </enum>
 
 <enum name="EnterprisePolicyInvalidations" type="int">