Reusing names of policy keys from policy_constants.h

chrome/browser/policy/configuration_policy_handler_list_factory.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/configuration_policy_handler_list_factory.h"
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/memory/scoped_vector.h"
 #include "base/values.h"
@@ skipping 257 matching lines @@
     base::Value::TYPE_BOOLEAN },
   { key::kRemoteAccessHostDomain,
     prefs::kRemoteAccessHostDomain,
     base::Value::TYPE_STRING },
   { key::kRemoteAccessHostTalkGadgetPrefix,
     prefs::kRemoteAccessHostTalkGadgetPrefix,
     base::Value::TYPE_STRING },
   { key::kRemoteAccessHostRequireCurtain,
     prefs::kRemoteAccessHostRequireCurtain,
     base::Value::TYPE_BOOLEAN },
+  { key::kRemoteAccessHostMatchUsername,
+    prefs::kRemoteAccessHostMatchUsername,
+    base::Value::TYPE_BOOLEAN },
+  { key::kRemoteAccessHostTokenUrl,
+    prefs::kRemoteAccessHostTokenUrl,
+    base::Value::TYPE_STRING },
+  { key::kRemoteAccessHostTokenValidationUrl,
+    prefs::kRemoteAccessHostTokenValidationUrl,
+    base::Value::TYPE_STRING },
+  { key::kRemoteAccessHostTokenValidationCertificateIssuer,
+    prefs::kRemoteAccessHostTokenValidationCertificateIssuer,
+    base::Value::TYPE_STRING },
+  { key::kRemoteAccessHostDebugOverridePolicies,
+    prefs::kRemoteAccessHostDebugOverridePolicies,
+    base::Value::TYPE_STRING },

[Mattias Nissler (ping if slow), 2015/01/05 09:45:33]

If I'm not mistaken, you're not using Chrome's PrefService instances to read
policy. If that is the case you don't need the changes here and you don't need
to introduce pref names either. The same probably goes for the other remoting
policy->pref mappings already present in this file? Maybe I'm missing something,
you may want to try to remove all of them and see whether things still work or
not ;)

[Łukasz Anforowicz, 2015/01/05 19:40:23]

Correct - current code doesn't use Chrome's PrefService and instead directly
reads content of json files from under /etc/opt/chrome/policies/managed/ (this
will hopefully be replaced by using ConfigDirPolicyLoader in
crrev.com/830193002).

In PatchSet #3, I've removed the old Chromoting entries from current file and
from pref_names.cc and pref_names.h.  I also removed "pref_mappings" property
from Chromoting policy entries in policy_test_cases.json.  It seems that try
bots are happy so far (the 3 failures seem unrelated to my changes).  I hope
that "git cl try" includes whatever testcases cover these 4 files.

   { key::kRemoteAccessHostAllowClientPairing,
     prefs::kRemoteAccessHostAllowClientPairing,
     base::Value::TYPE_BOOLEAN },
   { key::kRemoteAccessHostAllowGnubbyAuth,
     prefs::kRemoteAccessHostAllowGnubbyAuth,
     base::Value::TYPE_BOOLEAN },
   { key::kRemoteAccessHostAllowRelayedConnection,
     prefs::kRemoteAccessHostAllowRelayedConnection,
     base::Value::TYPE_BOOLEAN },
   { key::kRemoteAccessHostUdpPortRange,
@@ skipping 531 matching lines @@
           chrome_schema,
           SCHEMA_STRICT,
           SimpleSchemaValidatingPolicyHandler::RECOMMENDED_ALLOWED,
           SimpleSchemaValidatingPolicyHandler::MANDATORY_PROHIBITED)));
 #endif  // defined(OS_CHROMEOS)
 
   return handlers.Pass();
 }
 
 }  // namespace policy