tools/metrics/histograms/histograms.xml - Issue 820133002: Reusing names of policy keys from policy_constants.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 820133002: Reusing names of policy keys from policy_constants.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tweaks to policy_templates.json as suggested by Sergey and Bartosz. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 6a2c26fcc6bed77f1899a56205c5cbe18f40233b..f6fd057170690fa449f76508669e416f15f73269 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -45088,6 +45088,11 @@ Therefore, the affected-histogram name has to have at least one dot in it.

+ <int value="285" label="RemoteAccessHostMatchUsername"/>

bartfab (slow) 2015/01/13 18:49:45 You should copy the policy |caption|s, not the |na

Łukasz Anforowicz 2015/01/13 20:10:24 Errr... ok. The |name|s looked cleaner and more d

+ <int value="286" label="RemoteAccessHostTokenUrl"/>

+ <int value="287" label="RemoteAccessHostTokenValidationUrl"/>

+ <int value="288" label="RemoteAccessHostTokenValidationCertificateIssuer"/>

+ <int value="289" label="RemoteAccessHostDebugOverridePolicies"/>

</enum>

« components/policy/resources/policy_templates.json ('K') | « remoting/remoting_test.gypi ('k') | no next file » | no next file with comments »