Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 820123002: Use O_NONBLOCK when opening audio pipe on linux. (Closed)

Created:
6 years ago by Sergey Ulanov
Modified:
6 years ago
Reviewers:
Lambros
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use O_NONBLOCK when opening audio pipe on linux. By default open() blocks when opening a fifo until the writer also opens the fifo. In the past AudioPipeReader was using O_NONBLOCK when opening the pipe for reading, but that was changed in r277315, and may result in host hanging if pulseaudio doesn't open the pipe for some reason. Fixed AudioPipeReader to always pass O_NONBLOCK to open(). BUG=420090 R=lambroslambrou@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/2456707799f5ee29ccd0ccf7ba530d205115803c

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M remoting/host/linux/audio_pipe_reader.cc View 2 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Sergey Ulanov
6 years ago (2014-12-23 23:39:57 UTC) #3
Lambros
lgtm
6 years ago (2014-12-23 23:58:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820123002/20001
6 years ago (2014-12-24 00:03:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/28731)
6 years ago (2014-12-24 00:11:39 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2456707799f5ee29ccd0ccf7ba530d205115803c Cr-Commit-Position: refs/heads/master@{#309592}
6 years ago (2014-12-24 00:38:37 UTC) #9
Sergey Ulanov
6 years ago (2014-12-24 00:38:38 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
2456707799f5ee29ccd0ccf7ba530d205115803c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698