[Findit] Add a sub-pipeline to detect first-known failure.

appengine/findit/model/build.py

 # Copyright (c) 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-import calendar
-
 from google.appengine.ext import ndb
 
-from model.build_analysis_status import BuildAnalysisStatus
-
 
 class Build(ndb.Model):
   """Represent a build cycle of a builder in a waterfall."""
 
   @staticmethod
   def CreateKey(master_name, builder_name, build_number):  # pragma: no cover
     return ndb.Key(
         'Master', master_name, 'Builder', builder_name, 'Build', build_number)
 
   @staticmethod
   def CreateBuild(master_name, builder_name, build_number):  # pragma: no cover
     """Create a Build instance, but not save it to datastore."""

[qyearsley, 2014/12/29 19:44:53]

1. In general, the verb for a docstring is in third-person singular form, e.g.
"Creates a Build instance...".

2. s/but not/but does not/

IMO, this whole docstring is probably unnecessary (same in build.py). You could
probably remove this docstring entirely and it would still be pretty clear what
the function does just by looking at the one line below.

[stgao, 2015/01/03 01:31:46]

Good catch!
Docstring Removed.

     return Build(key=Build.CreateKey(master_name, builder_name, build_number),
                  master_name=master_name,
                  builder_name=builder_name,
                  build_number=build_number)
 
   @staticmethod
   def GetBuild(master_name, builder_name, build_number):  # pragma: no cover
     return Build.CreateKey(master_name, builder_name, build_number).get()
 
-  def Reset(self):
-    """Reset to the state as if no analysis is run."""
-    self.analysis_status = BuildAnalysisStatus.PENDING
-    self.analysis_start_time = None
-    self.analysis_updated_time = None
-
-  # Information of the build.
   master_name = ndb.StringProperty(indexed=False)
   builder_name = ndb.StringProperty(indexed=False)
   build_number = ndb.IntegerProperty(indexed=False)
 
-  # Information of analysis processing.
-  analysis_status = ndb.IntegerProperty(
-      default=BuildAnalysisStatus.PENDING, indexed=False)
-  analysis_start_time = ndb.DateTimeProperty(indexed=False)
-  analysis_updated_time = ndb.DateTimeProperty(indexed=False)
+  data = ndb.JsonProperty(indexed=False, compressed=True)
+  last_crawled_time = ndb.DateTimeProperty(indexed=False)
+
+  start_time = ndb.DateTimeProperty(indexed=False)
+  completed = ndb.BooleanProperty(default=False, indexed=False)
+  result = ndb.IntegerProperty(indexed=False)