Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 820103002: Add |is_encrypted| in mojo AudioDecoderConfig. (Closed)

Created:
6 years ago by xhwang
Modified:
6 years ago
Reviewers:
jrummell
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add |is_encrypted| in mojo AudioDecoderConfig. We need it to supported encrypted media playback. Note that |is_encrypted| is already in VideoDecoderConfig. BUG=432998 TEST=Added unittest to cover this. R=jrummell@chromium.org Committed: https://crrev.com/f6c45017858d62e8e0ac1ce8a1c45bfe59b17b8e Cr-Commit-Position: refs/heads/master@{#309618}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M media/mojo/interfaces/media_types.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M media/mojo/services/media_type_converters.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/mojo/services/media_type_converters_unittest.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
xhwang
6 years ago (2014-12-23 22:19:43 UTC) #1
jrummell
lgtm
6 years ago (2014-12-23 23:29:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820103002/1
6 years ago (2014-12-23 23:40:02 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/45448)
6 years ago (2014-12-23 23:49:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820103002/1
6 years ago (2014-12-24 04:40:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-24 05:23:37 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-24 05:24:41 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f6c45017858d62e8e0ac1ce8a1c45bfe59b17b8e
Cr-Commit-Position: refs/heads/master@{#309618}

Powered by Google App Engine
This is Rietveld 408576698