Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 820093006: Less fatal errors (Closed)

Created:
5 years, 11 months ago by ahe
Modified:
5 years, 11 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/less_fatal
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 12

Patch Set 2 : Merged with r42729. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M dart/pkg/compiler/lib/src/resolution/members.dart View 3 chunks +14 lines, -11 lines 0 comments Download
M dart/tests/language/language_dart2js.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
ahe
5 years, 11 months ago (2015-01-09 01:14:41 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/820093006/diff/1/dart/pkg/compiler/lib/src/resolution/members.dart File dart/pkg/compiler/lib/src/resolution/members.dart (right): https://codereview.chromium.org/820093006/diff/1/dart/pkg/compiler/lib/src/resolution/members.dart#newcode2275 dart/pkg/compiler/lib/src/resolution/members.dart:2275: element = warnAndCreateErroneousElement( Add a TODO to create ...
5 years, 11 months ago (2015-01-09 08:44:18 UTC) #3
ahe
Thank you, Johnni! https://codereview.chromium.org/820093006/diff/1/dart/pkg/compiler/lib/src/resolution/members.dart File dart/pkg/compiler/lib/src/resolution/members.dart (right): https://codereview.chromium.org/820093006/diff/1/dart/pkg/compiler/lib/src/resolution/members.dart#newcode2275 dart/pkg/compiler/lib/src/resolution/members.dart:2275: element = warnAndCreateErroneousElement( On 2015/01/09 08:44:17, ...
5 years, 11 months ago (2015-01-09 10:43:46 UTC) #4
Johnni Winther
https://codereview.chromium.org/820093006/diff/1/dart/pkg/compiler/lib/src/resolution/members.dart File dart/pkg/compiler/lib/src/resolution/members.dart (right): https://codereview.chromium.org/820093006/diff/1/dart/pkg/compiler/lib/src/resolution/members.dart#newcode2275 dart/pkg/compiler/lib/src/resolution/members.dart:2275: element = warnAndCreateErroneousElement( On 2015/01/09 10:43:46, ahe wrote: > ...
5 years, 11 months ago (2015-01-09 11:12:47 UTC) #5
ahe
Committed patchset #2 (id:20001) manually as 42731 (presubmit successful).
5 years, 11 months ago (2015-01-09 11:28:12 UTC) #6
ahe
5 years, 11 months ago (2015-01-09 11:43:24 UTC) #7
Message was sent while issue was closed. 
Thank you, Johnni!

Following up in CL 837563004.

https://codereview.chromium.org/820093006/diff/1/dart/pkg/compiler/lib/src/re...
File dart/pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/820093006/diff/1/dart/pkg/compiler/lib/src/re...
dart/pkg/compiler/lib/src/resolution/members.dart:2275: element =
warnAndCreateErroneousElement(
On 2015/01/09 11:12:47, Johnni Winther wrote:
> On 2015/01/09 10:43:46, ahe wrote:
> > On 2015/01/09 08:44:17, Johnni Winther wrote:
> > > Add a TODO to create a more precise erroneous element kind.
> > 
> > Are you suggesting that we decode allowedCategory and create a matching
> element?
> 
> Yes.

Done in CL 837563004.

https://codereview.chromium.org/820093006/diff/1/dart/pkg/compiler/lib/src/re...
dart/pkg/compiler/lib/src/resolution/members.dart:4925: element = new
ErroneousElementX(
On 2015/01/09 11:12:47, Johnni Winther wrote:
> On 2015/01/09 10:43:46, ahe wrote:
> > On 2015/01/09 08:44:18, Johnni Winther wrote:
> > > Ditto.
> > 
> > Are you thinking of an element like this:
> > 
> > class ErroneousConstructorX extends ErroneousElementX {
> > ...
> > }
> 
> Yes.

Done in CL 837563004.

https://codereview.chromium.org/820093006/diff/1/dart/pkg/compiler/lib/src/re...
dart/pkg/compiler/lib/src/resolution/members.dart:4931: element = new
ErroneousElementX(
On 2015/01/09 08:44:18, Johnni Winther wrote:
> Ditto.

Done in CL 837563004.

https://codereview.chromium.org/820093006/diff/1/dart/pkg/compiler/lib/src/re...
dart/pkg/compiler/lib/src/resolution/members.dart:4936: element = new
ErroneousElementX(
On 2015/01/09 08:44:18, Johnni Winther wrote:
> Ditto.

Done in CL 837563004.

Powered by Google App Engine
This is Rietveld 408576698