tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/client_type.py - Issue 820093002: Integration tests for desktop platforms and safebrowsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/client_type.py

Issue 820093002: Integration tests for desktop platforms and safebrowsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed code review comments. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py ('K') | « tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py ('k') | tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/smoke.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/client_type.py

diff --git a/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/client_type.py b/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/client_type.py

index 10dae71830441c4038707b2c46742ce26e632647..c96b10e6ef999cb124218014ac772be495ec4531 100644

--- a/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/client_type.py

+++ b/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/client_type.py

@@ -54,3 +54,21 @@ class ClientTypePageSet(page_set_module.PageSet):

url='http://check.googlezip.net/chrome-proxy-header/c=IOS',

page_set=self,

bypass_for_client_type='ios'))

+ # Page that should cause a bypass for linux clients.

+ self.AddUserStory(ClientTypePage(

+ url='http://check.googlezip.net/chrome-proxy-header/c=LINUX',

+ page_set=self,

+ bypass_for_client_type='linux'))

+ # Page that should cause a bypass for Windows clients.

+ self.AddUserStory(ClientTypePage(

+ url='http://check.googlezip.net/chrome-proxy-header/c=WIN',

+ page_set=self,

+ bypass_for_client_type='win'))

+ # Page that should cause a bypass for ChromeOS clients.

+ self.AddUserStory(ClientTypePage(

+ url='http://check.googlezip.net/chrome-proxy-header/c=CHROMEOS',

+ page_set=self,

+ bypass_for_client_type='chromeos'))