| Index: tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py
|
| diff --git a/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py b/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py
|
| index eadc0104ee2a554358a1f35a890b04116749c0d2..b70b799e6eead84b84868bc021b177b03d49cd0b 100644
|
| --- a/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py
|
| +++ b/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py
|
| @@ -139,19 +139,27 @@ class ChromeProxyBlockOnce(ChromeProxyValidation):
|
| self._metrics.AddResultsForBlockOnce(tab, results)
|
|
|
|
|
| -class ChromeProxySafebrowsing(ChromeProxyValidation):
|
| +class ChromeProxySafebrowsingMobile(ChromeProxyValidation):
|
| """Correctness measurement for safebrowsing."""
|
|
|
| def __init__(self):
|
| - super(ChromeProxySafebrowsing, self).__init__()
|
| + super(ChromeProxySafebrowsingMobile, self).__init__()
|
|
|
| def WillNavigateToPage(self, page, tab):
|
| - super(ChromeProxySafebrowsing, self).WillNavigateToPage(page, tab)
|
| + super(ChromeProxySafebrowsingMobile, self).WillNavigateToPage(page, tab)
|
| self._expect_timeout = True
|
|
|
| def AddResults(self, tab, results):
|
| - self._metrics.AddResultsForSafebrowsing(tab, results)
|
| + self._metrics.AddResultsForSafebrowsingMobile(tab, results)
|
|
|
| +class ChromeProxySafebrowsingDesktop(ChromeProxyValidation):
|
| + """Correctness measurement for safebrowsing."""
|
| +
|
| + def __init__(self):
|
| + super(ChromeProxySafebrowsingDesktop, self).__init__()
|
| +
|
| + def AddResults(self, tab, results):
|
| + self._metrics.AddResultsForSafebrowsingDesktop(tab, results)
|
|
|
| _FAKE_PROXY_AUTH_VALUE = 'aabbccdd3b7579186c1b0620614fdb1f0000ffff'
|
| _TEST_SERVER = 'chromeproxy-test.appspot.com'
|
| @@ -329,8 +337,6 @@ class ChromeProxySmoke(ChromeProxyValidation):
|
|
|
| def WillNavigateToPage(self, page, tab):
|
| super(ChromeProxySmoke, self).WillNavigateToPage(page, tab)
|
| - if page.name == 'safebrowsing':
|
| - self._expect_timeout = True
|
|
|
| def AddResults(self, tab, results):
|
| # Map a page name to its AddResults func.
|
| @@ -349,7 +355,6 @@ class ChromeProxySmoke(ChromeProxyValidation):
|
| self._metrics.AddResultsForDataSaving,
|
| ],
|
| 'bypass': [self._metrics.AddResultsForBypass],
|
| - 'safebrowsing': [self._metrics.AddResultsForSafebrowsing],
|
| }
|
| if not self._page.name in page_to_metrics:
|
| raise page_test.MeasurementFailure(
|
|
|