Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 820073009: Re-enables smart deploy by default. (Closed)

Created:
5 years, 11 months ago by rsadam
Modified:
5 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enables smart deploy by default. TBR=cpu TEST=VirtualKeyboardControllerTest, VirtualKeyboardControllerAutoTest Committed: https://crrev.com/bf658224ac2b7a6a6e57d77f2238a07a35ab26f9 Cr-Commit-Position: refs/heads/master@{#312213}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -18 lines) Patch
M ash/system/ime/tray_ime_chromeos_unittest.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M ash/virtual_keyboard_controller.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ash/virtual_keyboard_controller_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M ui/keyboard/keyboard_switches.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/keyboard/keyboard_switches.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
rsadam
Hi Sky, PTAL. It's a revert of issue 834733004 since branch cutoff has now passed.
5 years, 11 months ago (2015-01-20 16:22:24 UTC) #2
sky
LGTM
5 years, 11 months ago (2015-01-20 16:48:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820073009/20001
5 years, 11 months ago (2015-01-20 16:49:26 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-20 16:53:23 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 16:54:26 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/bf658224ac2b7a6a6e57d77f2238a07a35ab26f9
Cr-Commit-Position: refs/heads/master@{#312213}

Powered by Google App Engine
This is Rietveld 408576698