tools/perf/page_sets/key_mobile_sites_repaint.py - Issue 820063003: [Telemetry] Rename RunRepaint to RunPageInteractions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/key_mobile_sites_repaint.py

Issue 820063003: [Telemetry] Rename RunRepaint to RunPageInteractions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/key_mobile_sites_repaint.py

diff --git a/tools/perf/page_sets/key_mobile_sites_repaint.py b/tools/perf/page_sets/key_mobile_sites_repaint.py

index cc2a056864c367b58ba576b848c4db5589c016e0..bc2606270311c3fd44b58353c971c510da728b45 100644

--- a/tools/perf/page_sets/key_mobile_sites_repaint.py

+++ b/tools/perf/page_sets/key_mobile_sites_repaint.py

@@ -14,7 +14,7 @@ def _RepaintContinously(action_runner):

def _CreatePageClassWithRepaintInteractions(page_cls):

class DerivedRepaintPage(page_cls): # pylint: disable=W0232

- def RunRepaintness(self, action_runner):

+ def RunPageInteractionsness(self, action_runner):

sullivan 2014/12/23 16:44:25 What is the "ness" in "RunPageInteractionsness"?

nednguyen 2014/12/23 16:52:45 Err, I did a sed & turnout there was ness in as in

sullivan 2014/12/23 16:54:39 Makes sense. Should it just be RunPageInteractions

nednguyen 2014/12/23 16:56:28 Done.

_RepaintContinously(action_runner)

return DerivedRepaintPage

@@ -28,7 +28,7 @@ class KeyMobileSitesRepaintPage(page_module.Page):

self.user_agent_type = 'mobile'

self.archive_data_file = 'data/key_mobile_sites_repaint.json'

- def RunRepaintness(self, action_runner):

+ def RunPageInteractionsness(self, action_runner):

_RepaintContinously(action_runner)

« no previous file with comments | « tools/perf/measurements/repaint_unittest.py ('k') | tools/perf/page_sets/top_25_repaint.py » ('j') | no next file with comments »