Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 820063003: [Telemetry] Rename RunRepaint to RunPageInteractions (Closed)

Created:
6 years ago by nednguyen
Modified:
6 years ago
Reviewers:
sullivan, ernstm
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Rename RunRepaint to RunPageInteractions BUG=418375 Committed: https://crrev.com/1fac4392e8b1cca3d15e55184014106661bb6214 Cr-Commit-Position: refs/heads/master@{#309559}

Patch Set 1 #

Total comments: 4

Patch Set 2 : RunPageInteractionsness -> RunPageInteractions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M tools/perf/measurements/measurement_smoke_test.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/perf/measurements/repaint.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/repaint_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/key_mobile_sites_repaint.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/top_25_repaint.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
nednguyen
6 years ago (2014-12-23 16:12:14 UTC) #2
sullivan
https://codereview.chromium.org/820063003/diff/1/tools/perf/page_sets/key_mobile_sites_repaint.py File tools/perf/page_sets/key_mobile_sites_repaint.py (right): https://codereview.chromium.org/820063003/diff/1/tools/perf/page_sets/key_mobile_sites_repaint.py#newcode17 tools/perf/page_sets/key_mobile_sites_repaint.py:17: def RunPageInteractionsness(self, action_runner): What is the "ness" in "RunPageInteractionsness"?
6 years ago (2014-12-23 16:44:25 UTC) #3
nednguyen
https://codereview.chromium.org/820063003/diff/1/tools/perf/page_sets/key_mobile_sites_repaint.py File tools/perf/page_sets/key_mobile_sites_repaint.py (right): https://codereview.chromium.org/820063003/diff/1/tools/perf/page_sets/key_mobile_sites_repaint.py#newcode17 tools/perf/page_sets/key_mobile_sites_repaint.py:17: def RunPageInteractionsness(self, action_runner): On 2014/12/23 16:44:25, sullivan wrote: > ...
6 years ago (2014-12-23 16:52:45 UTC) #4
nednguyen
https://codereview.chromium.org/820063003/diff/1/tools/perf/page_sets/key_mobile_sites_repaint.py File tools/perf/page_sets/key_mobile_sites_repaint.py (right): https://codereview.chromium.org/820063003/diff/1/tools/perf/page_sets/key_mobile_sites_repaint.py#newcode17 tools/perf/page_sets/key_mobile_sites_repaint.py:17: def RunPageInteractionsness(self, action_runner): On 2014/12/23 16:44:25, sullivan wrote: > ...
6 years ago (2014-12-23 16:52:45 UTC) #5
sullivan
https://codereview.chromium.org/820063003/diff/1/tools/perf/page_sets/key_mobile_sites_repaint.py File tools/perf/page_sets/key_mobile_sites_repaint.py (right): https://codereview.chromium.org/820063003/diff/1/tools/perf/page_sets/key_mobile_sites_repaint.py#newcode17 tools/perf/page_sets/key_mobile_sites_repaint.py:17: def RunPageInteractionsness(self, action_runner): On 2014/12/23 16:52:45, nednguyen wrote: > ...
6 years ago (2014-12-23 16:54:39 UTC) #6
nednguyen
https://codereview.chromium.org/820063003/diff/1/tools/perf/page_sets/key_mobile_sites_repaint.py File tools/perf/page_sets/key_mobile_sites_repaint.py (right): https://codereview.chromium.org/820063003/diff/1/tools/perf/page_sets/key_mobile_sites_repaint.py#newcode17 tools/perf/page_sets/key_mobile_sites_repaint.py:17: def RunPageInteractionsness(self, action_runner): On 2014/12/23 16:54:39, sullivan wrote: > ...
6 years ago (2014-12-23 16:56:28 UTC) #7
sullivan
lgtm
6 years ago (2014-12-23 16:56:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820063003/20001
6 years ago (2014-12-23 16:58:07 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-23 18:17:33 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-23 18:19:05 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1fac4392e8b1cca3d15e55184014106661bb6214
Cr-Commit-Position: refs/heads/master@{#309559}

Powered by Google App Engine
This is Rietveld 408576698