chrome/browser/autocomplete/zero_suggest_provider.h - Issue 820063002: Add support for providers called when the omnibox is focused.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/zero_suggest_provider.h

Issue 820063002: Add support for providers called when the omnibox is focused. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autocomplete/autocomplete_controller.cc ('K') | « chrome/browser/autocomplete/autocomplete_controller.cc ('k') | chrome/browser/autocomplete/zero_suggest_provider.cc » ('j') | components/omnibox/autocomplete_provider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/zero_suggest_provider.h

diff --git a/chrome/browser/autocomplete/zero_suggest_provider.h b/chrome/browser/autocomplete/zero_suggest_provider.h

index 6048c0c040920a6ca0504de99b48ecfc865d87d0..8ea66291066a0a881dda841436fda91697db8608 100644

--- a/chrome/browser/autocomplete/zero_suggest_provider.h

+++ b/chrome/browser/autocomplete/zero_suggest_provider.h

@@ -37,7 +37,7 @@ class PrefRegistrySyncable;

// Autocomplete provider for searches based on the current URL.

-// The controller will call StartZeroSuggest when the user focuses in the

+// The controller will call StartOnOmniboxFocus when the user focuses in the

Peter Kasting 2014/12/30 21:18:23 Nit: While here, remove "in"

jif 2014/12/31 19:02:26 Done.

// omnibox. After construction, the autocomplete controller repeatedly calls

// Start() with some user input, each time expecting to receive an updated

// set of matches.

@@ -61,6 +61,7 @@ class ZeroSuggestProvider : public BaseSearchProvider,

void Stop(bool clear_cached_results) override;

void DeleteMatch(const AutocompleteMatch& match) override;

void AddProviderInfo(ProvidersInfo* provider_info) const override;

+ bool ActivatedOnOmniboxFocus() const override;

// Sets |field_trial_triggered_| to false.

void ResetSession() override;