Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: chrome/browser/autocomplete/autocomplete_controller.h

Issue 820063002: Add support for providers called when the omnibox is focused. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/autocomplete_controller.h
diff --git a/chrome/browser/autocomplete/autocomplete_controller.h b/chrome/browser/autocomplete/autocomplete_controller.h
index e834777568883693787dcf4c8e4b69c7e797b42a..bd03b092be499cfc308134eca86254fae5f4093c 100644
--- a/chrome/browser/autocomplete/autocomplete_controller.h
+++ b/chrome/browser/autocomplete/autocomplete_controller.h
@@ -80,10 +80,10 @@ class AutocompleteController : public AutocompleteProviderListener {
// If |clear_result| is true, the controller will also erase the result set.
void Stop(bool clear_result);
- // Begin asynchronous fetch of zero-suggest suggestions. The |input| should
- // contain current omnibox input, the URL of the page we are on, and
- // that page's classification.
- void StartZeroSuggest(const AutocompleteInput& input);
+ // Begin asynchronous fetch of suggestions to be shown when the omnibox is
+ // focused. The |input| should contain current omnibox input, the URL of the
+ // page we are on, and that page's classification.
+ void StartOnOmniboxFocus(const AutocompleteInput& input);
Peter Kasting 2014/12/30 21:18:23 Nit: How about this comment and name: // Called
jif 2014/12/31 19:02:26 Done.
// Asks the relevant provider to delete |match|, and ensures observers are
// notified of resulting changes immediately. This should only be called when
@@ -211,6 +211,10 @@ class AutocompleteController : public AutocompleteProviderListener {
ZeroSuggestProvider* zero_suggest_provider_;
+ // Returns whether |providers_| contains providers that are started when the
+ // omnibox is focused.
+ bool has_providers_for_omnibox_focus_;
+
// Input passed to Start.
AutocompleteInput input_;

Powered by Google App Engine
This is Rietveld 408576698