Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: chrome/browser/autocomplete/autocomplete_controller.cc

Issue 820063002: Add support for providers called when the omnibox is focused. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix android build. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/autocomplete_controller.cc
diff --git a/chrome/browser/autocomplete/autocomplete_controller.cc b/chrome/browser/autocomplete/autocomplete_controller.cc
index 627b1a79f20d05b18523680173d39911f770a20d..b23c215c4b380903b0a564ce4acc63f74e81e679 100644
--- a/chrome/browser/autocomplete/autocomplete_controller.cc
+++ b/chrome/browser/autocomplete/autocomplete_controller.cc
@@ -327,24 +327,20 @@ void AutocompleteController::Stop(bool clear_result) {
}
}
-void AutocompleteController::StartZeroSuggest(const AutocompleteInput& input) {
- if (zero_suggest_provider_ == NULL)
- return;
-
+void AutocompleteController::OnOmniboxFocused(const AutocompleteInput& input) {
DCHECK(!in_start_); // We should not be already running a query.
// Call Start() on all prefix-based providers with an INVALID
// AutocompleteInput to clear out cached |matches_|, which ensures that
// they aren't used with zero suggest.
for (Providers::iterator i(providers_.begin()); i != providers_.end(); ++i) {
- if (i->get() == zero_suggest_provider_)
+ if ((*i)->ProvidesMatchesOnOmniboxFocus())
(*i)->Start(input, false);
else
(*i)->Start(AutocompleteInput(), false);
}
- if (!zero_suggest_provider_->matches().empty())
- UpdateResult(false, false);
+ UpdateResult(false, false);
}
void AutocompleteController::DeleteMatch(const AutocompleteMatch& match) {
« no previous file with comments | « chrome/browser/autocomplete/autocomplete_controller.h ('k') | chrome/browser/autocomplete/zero_suggest_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698