chrome/browser/android/omnibox/autocomplete_controller_android.cc - Issue 820063002: Add support for providers called when the omnibox is focused.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/omnibox/autocomplete_controller_android.cc

Issue 820063002: Add support for providers called when the omnibox is focused. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix android build. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/omnibox/autocomplete_controller_android.h ('k') | chrome/browser/autocomplete/autocomplete_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/omnibox/autocomplete_controller_android.cc

diff --git a/chrome/browser/android/omnibox/autocomplete_controller_android.cc b/chrome/browser/android/omnibox/autocomplete_controller_android.cc

index daa9ce877f7f81fd4c8d3dbaec1d143bddbb5872..8818328668097092efe3a3dcf947d1e9bc7b784c 100644

--- a/chrome/browser/android/omnibox/autocomplete_controller_android.cc

+++ b/chrome/browser/android/omnibox/autocomplete_controller_android.cc

@@ -64,7 +64,7 @@ const int kAndroidAutocompleteProviders =

/**

* A prefetcher class responsible for triggering zero suggest prefetch.

- * The prefetch occurs as a side-effect of calling StartZeroSuggest() on

+ * The prefetch occurs as a side-effect of calling OnOmniboxFocused() on

* the AutocompleteController object.

class ZeroSuggestPrefetcher : public AutocompleteControllerDelegate {

@@ -90,7 +90,7 @@ ZeroSuggestPrefetcher::ZeroSuggestPrefetcher(Profile* profile)

// AutocompleteInput object.

base::string16 fake_request_source(base::ASCIIToUTF16(

"http://www.foobarbazblah.com"));

- controller_->StartZeroSuggest(AutocompleteInput(

+ controller_->OnOmniboxFocused(AutocompleteInput(

fake_request_source, base::string16::npos, std::string(),

GURL(fake_request_source), OmniboxEventProto::INVALID_SPEC, false, false,

true, true, ChromeAutocompleteSchemeClassifier(profile)));

@@ -161,7 +161,7 @@ ScopedJavaLocalRef<jobject> AutocompleteControllerAndroid::Classify(

return GetTopSynchronousResult(env, obj, j_text, true);

}

-void AutocompleteControllerAndroid::StartZeroSuggest(

+void AutocompleteControllerAndroid::OnOmniboxFocused(

JNIEnv* env,

jobject obj,

jstring j_omnibox_text,

@@ -184,7 +184,7 @@ void AutocompleteControllerAndroid::StartZeroSuggest(

omnibox_text, base::string16::npos, std::string(), current_url,

ClassifyPage(current_url, is_query_in_omnibox, focused_from_fakebox),

false, false, true, true, ChromeAutocompleteSchemeClassifier(profile_));

- autocomplete_controller_->StartZeroSuggest(input_);

+ autocomplete_controller_->OnOmniboxFocused(input_);

}

void AutocompleteControllerAndroid::Stop(JNIEnv* env,