Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 820053003: [Android] Disable the deletions-only check for findbugs_known_bugs.txt. (Closed)

Created:
5 years, 11 months ago by jbudorick
Modified:
5 years, 11 months ago
Reviewers:
klundberg
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Disable the deletions-only check for findbugs_known_bugs.txt. The deletions-only check is causing a lot of issues with the upstreaming effort, so I'm disabling it temporarily. BUG= Committed: https://crrev.com/d4646647dea3fa62f5682af240009b9dbf29b4b9 Cr-Commit-Position: refs/heads/master@{#311476}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/android/PRESUBMIT.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jbudorick
5 years, 11 months ago (2015-01-14 00:13:37 UTC) #2
klundberg
lgtm
5 years, 11 months ago (2015-01-14 02:45:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820053003/1
5 years, 11 months ago (2015-01-14 14:05:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 15:25:02 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 15:26:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4646647dea3fa62f5682af240009b9dbf29b4b9
Cr-Commit-Position: refs/heads/master@{#311476}

Powered by Google App Engine
This is Rietveld 408576698