Touch emulator: create/destroy gesture provider on the fly.

Touch emulator: create/destroy gesture provider on the fly.

This will allow to re-create gesture provider with different configs,
as requested by the user.

BUG=425586
Committed: https://crrev.com/fcd1b8b8abdb2f84a79822092cd35a34aadeb76a
Cr-Commit-Position: refs/heads/master@{#311503}

[dgozman, 2014-12-23 15:06:16]

dgozman@chromium.org changed reviewers:
+ jdduke@chromium.org, rbyers@chromium.org

[dgozman, 2014-12-23 15:06:17]

Could you please take a look?

[jdduke (slow), 2014-12-30 16:37:19]

On 2014/12/23 15:06:17, dgozman wrote:
> Could you please take a look?

Can we go ahead and merge this with https://codereview.chromium.org/821223002/?

https://codereview.chromium.org/820053002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/input/touch_emulator.cc (right):

https://codereview.chromium.org/820053002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/input/touch_emulator.cc:103: if
(!gesture_provider_)
In these early returns, would it make sense to use the |enabled()| query
instead?

https://codereview.chromium.org/820053002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/input/touch_emulator.cc:220:
DCHECK(gesture_provider_.get());
Do you need the ".get()" (also below)?

https://codereview.chromium.org/820053002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/input/touch_emulator.h (right):

https://codereview.chromium.org/820053002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/input/touch_emulator.h:28: bool enabled() const {
return !!gesture_provider_.get(); }
Does just "return gesture_provider_;" work?

[dgozman, 2015-01-14 14:14:27]

> Can we go ahead and merge this with
https://codereview.chromium.org/821223002/?

I am trying to separate mostly mechanical touch emulator refactoring from it's
public interface change.
PTAL

https://codereview.chromium.org/820053002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/input/touch_emulator.cc (right):

https://codereview.chromium.org/820053002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/input/touch_emulator.cc:103: if
(!gesture_provider_)
On 2014/12/30 16:37:19, jdduke wrote:
> In these early returns, would it make sense to use the |enabled()| query
> instead?

Great idea! Done.

https://codereview.chromium.org/820053002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/input/touch_emulator.cc:220:
DCHECK(gesture_provider_.get());
On 2014/12/30 16:37:19, jdduke wrote:
> Do you need the ".get()" (also below)?

Removed.

https://codereview.chromium.org/820053002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/input/touch_emulator.h (right):

https://codereview.chromium.org/820053002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/input/touch_emulator.h:28: bool enabled() const {
return !!gesture_provider_.get(); }
On 2014/12/30 16:37:19, jdduke wrote:
> Does just "return gesture_provider_;" work?

Done.

[jdduke (slow), 2015-01-14 15:45:56]

lgtm, assuming we have a test that exercises transitioning from enabled ->
disabled -> enabled.

[dgozman, 2015-01-14 16:09:16]

On 2015/01/14 15:45:56, jdduke wrote:
> lgtm, assuming we have a test that exercises transitioning from enabled ->
> disabled -> enabled.

Yes, it's a unit test called TouchEmulatorTest.DisableAndReenable.

[dgozman, 2015-01-14 16:09:18]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2015-01-14 16:10:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/820053002/20001

[commit-bot: I haz the power, 2015-01-14 16:15:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-14 16:15:24]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[dgozman, 2015-01-14 16:20:21]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2015-01-14 16:21:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/820053002/20001

[commit-bot: I haz the power, 2015-01-14 17:45:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-14 17:47:01]

Patchset 2 (id:??) landed as
https://crrev.com/fcd1b8b8abdb2f84a79822092cd35a34aadeb76a
Cr-Commit-Position: refs/heads/master@{#311503}