Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 819993002: Revert of Explicitly suppress scrolling for wheel events that will trigger zooming (Closed)

Created:
6 years ago by Yuta Kitamura
Modified:
6 years ago
CC:
chromium-reviews, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, jdduke+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Explicitly suppress scrolling for wheel events that will trigger zooming (patchset #10 id:360001 of https://codereview.chromium.org/739013008/) Reason for revert: Broke layout tests that use wheel events: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20XP/builds/15918 Original issue's description: > Explicitly suppress scrolling for wheel events that will trigger zooming > > We added a flag in Blink to decide if Ctrl-wheel-scroll should scroll or zoom, and now we use this flag in chromium code. > > This patch is part of a series: > > patch #1: https://codereview.chromium.org/759073002 > patch #2: This CL > patch #3: https://codereview.chromium.org/768443002 > > BUG=397027, 378755 > > Committed: https://crrev.com/b3361bcdd3766a67c702c19781154c895fee75ca > Cr-Commit-Position: refs/heads/master@{#309472} TBR=rbyers@chromium.org,tdresser@chromium.org,jdduke@chromium.org,sievers@chromium.org,lanwei@chromium.org NOTREECHECKS=true NOTRY=true BUG=397027, 378755 Committed: https://crrev.com/f3990fd7b7dad87b1b8c9b9f3dba97f64d06051b Cr-Commit-Position: refs/heads/master@{#309531}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -202 lines) Patch
M content/browser/renderer_host/input/input_router_impl.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 8 chunks +10 lines, -38 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 4 chunks +9 lines, -71 lines 0 comments Download
M content/browser/renderer_host/web_input_event_aura.cc View 1 chunk +2 lines, -11 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M content/common/input/synthetic_web_input_event_builders.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/input/web_input_event_traits.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M content/common/input/web_input_event_traits_unittest.cc View 2 chunks +0 lines, -36 lines 0 comments Download
M content/renderer/input/input_handler_proxy.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/input/input_handler_proxy_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/event_sender.cc View 2 chunks +9 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yuta Kitamura
Created Revert of Explicitly suppress scrolling for wheel events that will trigger zooming
6 years ago (2014-12-23 03:51:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/819993002/1
6 years ago (2014-12-23 03:52:08 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-23 03:53:05 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-23 03:53:59 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3990fd7b7dad87b1b8c9b9f3dba97f64d06051b
Cr-Commit-Position: refs/heads/master@{#309531}

Powered by Google App Engine
This is Rietveld 408576698