OOP PDF: Fix access to chrome://resources in print preview.

OOP PDF: Fix access to chrome://resources in print preview.

When the PDF extension is iframed by the print preview page, it isn't
granted permission to access chrome://resources. This CL causes the
extension to be granted access to chrome://resources in the renderer
process for print-preview by adding it as a content script for
chrome://print/*. This is a temporary work-around until either print
preview uses an embed element for the OOP PDF plugin or OOP iframe
allows extensions to run with their normal permissions when iframed.
This also removes the need for the work-around added in r306307.

BUG=437417, 444752
Committed: https://crrev.com/7626c7325b71eaef6589d1490258efcf3a16cbe2
Cr-Commit-Position: refs/heads/master@{#310044}

[Sam McNally, 2014-12-23 03:04:40]

Patchset #1 (id:1) has been deleted

[Sam McNally, 2014-12-23 03:09:55]

Patchset #1 (id:20001) has been deleted

[Sam McNally, 2014-12-23 03:16:03]

sammc@chromium.org changed reviewers:
+ raymes@chromium.org

[raymes, 2014-12-23 03:27:38]

lgtm

https://codereview.chromium.org/819983002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/pdf/manifest.json (right):

https://codereview.chromium.org/819983002/diff/40001/chrome/browser/resources...
chrome/browser/resources/pdf/manifest.json:31: "content_scripts": [
Please add a comment here about why this is needed and refer to the bug. We
could add a comment inside the js file too.

[Sam McNally, 2014-12-23 03:39:08]

sammc@chromium.org changed reviewers:
+ thestig@chromium.org

[Sam McNally, 2014-12-23 03:39:09]

+thestig for chrome/browser/resources/component_extension_resources.grd.

https://codereview.chromium.org/819983002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/pdf/manifest.json (right):

https://codereview.chromium.org/819983002/diff/40001/chrome/browser/resources...
chrome/browser/resources/pdf/manifest.json:31: "content_scripts": [
On 2014/12/23 03:27:38, raymes wrote:
> Please add a comment here about why this is needed and refer to the bug. We
> could add a comment inside the js file too.

Done.

[Lei Zhang, 2015-01-05 22:48:55]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2015-01-05 22:48:56]

lgtm

[commit-bot: I haz the power, 2015-01-05 22:50:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/819983002/60001

[commit-bot: I haz the power, 2015-01-05 22:59:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-05 22:59:24]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Sam McNally, 2015-01-05 23:04:49]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2015-01-05 23:05:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/819983002/100001

[commit-bot: I haz the power, 2015-01-05 23:49:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-05 23:49:53]

Failed to apply patch for chrome/browser/resources/pdf/manifest.json:
While running git apply --index -3 -p1;
  error: chrome/browser/resources/pdf/manifest.json: does not exist in index

Patch:       chrome/browser/resources/pdf/manifest.json
Index: chrome/browser/resources/pdf/manifest.json
diff --git a/chrome/browser/resources/pdf/manifest.json
b/chrome/browser/resources/pdf/manifest.json
index
f4c7c31294c01c9a6c15fb9a64fa8d4eed1b3503..1324302e6ad6d58f0e7eb0a16459deb51ac564d2
100644
--- a/chrome/browser/resources/pdf/manifest.json
+++ b/chrome/browser/resources/pdf/manifest.json
@@ -27,5 +27,14 @@
   "web_accessible_resources": [
     "index.html"
   ],
-  "content_security_policy": "script-src 'self' chrome://resources; object-src
*; plugin-types application/x-google-chrome-pdf"
+  "content_security_policy": "script-src 'self' chrome://resources; object-src
*; plugin-types application/x-google-chrome-pdf",
+  // This is to work-around an issue where this extension is not granted
+  // permission to access chrome://resources when iframed for print preview.
+  // See https://crbug.com/444752.
+  "content_scripts": [
+    {
+      "matches": ["chrome://print/*"],
+      "js": ["content_script.js"]
+    }
+  ]
 }

[commit-bot: I haz the power, 2015-01-05 23:50:01]

The CQ bit was unchecked by commit-bot@chromium.org

[Sam McNally, 2015-01-06 02:50:30]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2015-01-06 02:51:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/819983002/120001

[commit-bot: I haz the power, 2015-01-06 03:51:35]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2015-01-06 03:52:49]

Patchset 5 (id:??) landed as
https://crrev.com/7626c7325b71eaef6589d1490258efcf3a16cbe2
Cr-Commit-Position: refs/heads/master@{#310044}