Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Side by Side Diff: Source/bindings/templates/interface.cpp

Issue 819943006: [bindings] Let getShadowObjectTemplate return Local<>. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@third-branch
Patch Set: Created 5 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/templates/interface.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 {% extends 'interface_base.cpp' %} 1 {% extends 'interface_base.cpp' %}
2 2
3 3
4 {##############################################################################} 4 {##############################################################################}
5 {% block indexed_property_getter %} 5 {% block indexed_property_getter %}
6 {% if indexed_property_getter and not indexed_property_getter.is_custom %} 6 {% if indexed_property_getter and not indexed_property_getter.is_custom %}
7 {% set getter = indexed_property_getter %} 7 {% set getter = indexed_property_getter %}
8 static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo <v8::Value>& info) 8 static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo <v8::Value>& info)
9 { 9 {
10 {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder()); 10 {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder());
(...skipping 884 matching lines...) Expand 10 before | Expand all | Expand 10 after
895 return toImpl(wrapper); 895 return toImpl(wrapper);
896 } 896 }
897 897
898 {% endif %} 898 {% endif %}
899 {% endblock %} 899 {% endblock %}
900 900
901 901
902 {##############################################################################} 902 {##############################################################################}
903 {% block get_shadow_object_template %} 903 {% block get_shadow_object_template %}
904 {% if interface_name == 'Window' %} 904 {% if interface_name == 'Window' %}
905 v8::Handle<v8::ObjectTemplate> V8Window::getShadowObjectTemplate(v8::Isolate* is olate) 905 v8::Local<v8::ObjectTemplate> V8Window::getShadowObjectTemplate(v8::Isolate* iso late)
906 { 906 {
907 if (DOMWrapperWorld::current(isolate).isMainWorld()) { 907 if (DOMWrapperWorld::current(isolate).isMainWorld()) {
908 DEFINE_STATIC_LOCAL(v8::Persistent<v8::ObjectTemplate>, V8WindowShadowOb jectCacheForMainWorld, ()); 908 DEFINE_STATIC_LOCAL(v8::Persistent<v8::ObjectTemplate>, V8WindowShadowOb jectCacheForMainWorld, ());
909 if (V8WindowShadowObjectCacheForMainWorld.IsEmpty()) { 909 if (V8WindowShadowObjectCacheForMainWorld.IsEmpty()) {
910 TRACE_EVENT_SCOPED_SAMPLING_STATE("blink", "BuildDOMTemplate"); 910 TRACE_EVENT_SCOPED_SAMPLING_STATE("blink", "BuildDOMTemplate");
911 v8::Local<v8::ObjectTemplate> templ = v8::ObjectTemplate::New(isolat e); 911 v8::Local<v8::ObjectTemplate> templ = v8::ObjectTemplate::New(isolat e);
912 configureShadowObjectTemplate(templ, isolate); 912 configureShadowObjectTemplate(templ, isolate);
913 V8WindowShadowObjectCacheForMainWorld.Reset(isolate, templ); 913 V8WindowShadowObjectCacheForMainWorld.Reset(isolate, templ);
914 return templ; 914 return templ;
915 } 915 }
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
970 } 970 }
971 971
972 {% for method in methods if method.overloads and method.overloads.has_partial_ov erloads %} 972 {% for method in methods if method.overloads and method.overloads.has_partial_ov erloads %}
973 void {{v8_class}}::register{{method.name | blink_capitalize}}MethodForPartialInt erface(void (*method)(const v8::FunctionCallbackInfo<v8::Value>&)) 973 void {{v8_class}}::register{{method.name | blink_capitalize}}MethodForPartialInt erface(void (*method)(const v8::FunctionCallbackInfo<v8::Value>&))
974 { 974 {
975 {{cpp_class}}V8Internal::{{method.name}}MethodForPartialInterface = method; 975 {{cpp_class}}V8Internal::{{method.name}}MethodForPartialInterface = method;
976 } 976 }
977 {% endfor %} 977 {% endfor %}
978 {% endif %} 978 {% endif %}
979 {% endblock %} 979 {% endblock %}
OLDNEW
« no previous file with comments | « Source/bindings/templates/interface.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698