Issue 8199010: Fixing misleading name a in speech input setting and related variables.

Issue 8199010: Fixing misleading name a in speech input setting and related variables. (Closed)

Created:
9 years, 2 months ago by Leandro Gracia Gil

Modified:
9 years, 2 months ago

Reviewers:
Satish, Leandro Graciá Gil

CC:
chromium-reviews, Avi (use Gerrit), dpranke+watch-content_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fixing misleading name in a speech input setting and related variables. This patch replaces all occurrences of 'censor results' with 'filter profanities', which is a much accurate description of what it does and avoids unfortunate confusions. BUG=79991 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104653

Patch Set 1 #

Total comments: 4

Patch Set 2 : review fixes. Landing if no problems in the bots. #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -43 lines)			Patch
M	chrome/app/chrome_command_ids.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/app/generated_resources.grd	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/profiles/profile.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/profiles/profile_impl.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/speech/chrome_speech_input_preferences.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/speech/chrome_speech_input_preferences.cc	View	1	1 chunk	+9 lines, -8 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu.cc	View		4 chunks	+11 lines, -9 lines	0 comments	Download
M	chrome/common/pref_names.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/pref_names.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/speech/speech_input_manager.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/speech/speech_input_preferences.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/speech/speech_recognition_request.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/speech/speech_recognition_request.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/speech/speech_recognizer.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/speech/speech_recognizer.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	content/shell/shell_browser_context.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Satish

LGTM http://codereview.chromium.org/8199010/diff/1/chrome/browser/speech/chrome_speech_input_preferences.cc File chrome/browser/speech/chrome_speech_input_preferences.cc (right): http://codereview.chromium.org/8199010/diff/1/chrome/browser/speech/chrome_speech_input_preferences.cc#newcode14 chrome/browser/speech/chrome_speech_input_preferences.cc:14: // Migrate the old profanity filtering key to ...

9 years, 2 months ago (2011-10-07 20:09:26 UTC) #2

Leandro Graciá Gil

9 years, 2 months ago (2011-10-07 23:22:09 UTC) #3

Trying the bots after the review fixes. Landing if no problems found.

http://codereview.chromium.org/8199010/diff/1/chrome/browser/speech/chrome_sp...
File chrome/browser/speech/chrome_speech_input_preferences.cc (right):

http://codereview.chromium.org/8199010/diff/1/chrome/browser/speech/chrome_sp...
chrome/browser/speech/chrome_speech_input_preferences.cc:14: // Migrate the old
profanity filtering key to the new one.
Agreed. I'll leave a comment to make sure the old pref name is not
misinterpreted.

On 2011/10/07 20:09:26, Satish wrote:
> may be simpler to leave the name of the preference as is and not do all this
> migration

http://codereview.chromium.org/8199010/diff/1/chrome/common/pref_names.cc
File chrome/common/pref_names.cc (right):

http://codereview.chromium.org/8199010/diff/1/chrome/common/pref_names.cc#new...
chrome/common/pref_names.cc:611: const char
kSpeechInputCensorResultsDeprecated[] =
On 2011/10/07 20:09:26, Satish wrote:
> as mentioned earlier suggest just renaming this variable to FilterProfanities
> but leaving the string below as is.

Done.

Expand Messages | Collapse Messages