Issue 81983002: DevTools: tab selection after tabclose should not be a user gesture

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 81983002: DevTools: tab selection after tabclose should not be a user gesture (Closed)

Created:
7 years, 1 month ago by lushnikov

Modified:
7 years, 1 month ago

Reviewers:
vsevik

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: tab selection after tabclose should not be a user gesture This patch changes call to 'TabbedPane.selectTab' method to recieve false as 'userGesture' argument if it's done as a part of 'TabbedPane.closeTabs' method. This doesn't seem to change any behavior as the 'TabbedEditorContainer._updateHistory()' will be called anyway on the previous step of closing tabs, and subsequent call to this method from 'selectTab' will result in noop. BUG=281507 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162574

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/devtools/front_end/TabbedPane.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/81983002/1

7 years, 1 month ago (2013-11-23 02:08:55 UTC) #3

Message was sent while issue was closed.

Change committed as 162574

Expand Messages | Collapse Messages