Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: chrome/browser/web_applications/web_app.h

Issue 819823002: Fixed create application shortcuts on Windows/Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/web_applications/web_app.h
diff --git a/chrome/browser/web_applications/web_app.h b/chrome/browser/web_applications/web_app.h
index ff6b664a6d710a1888622c6910a6ca9706c0141c..e10bec8cbaceb056127e01ba130f85f6e857997a 100644
--- a/chrome/browser/web_applications/web_app.h
+++ b/chrome/browser/web_applications/web_app.h
@@ -168,16 +168,22 @@ std::string GetExtensionIdFromApplicationName(const std::string& app_name);
// |shortcut_info| contains information about the shortcuts to create, and
// |locations| contains information about where to create them, while
// |file_handlers_info| contains information about the file handlers to create.
+// The difference between this function and CreateNonAppShortcut, is that this
+// function ensures that both the profile and extension exists first.
void CreateShortcutsWithInfo(
ShortcutCreationReason reason,
const ShortcutLocations& locations,
const ShortcutInfo& shortcut_info,
const extensions::FileHandlersInfo& file_handlers_info);
-// Currently only called by app_list_service_mac to create a shim for the
-// app launcher.
-void CreateNonAppShortcut(const ShortcutLocations& locations,
- const ShortcutInfo& shortcut_info);
+// Currently only called by app_list_service_mac (to create a shim for the
+// app launcher) and create_application_shortcut_view (to create extension
+// shortcuts).
+void CreateNonAppShortcut(
+ ShortcutCreationReason reason,
+ const ShortcutLocations& locations,
+ const ShortcutInfo& shortcut_info,
+ const extensions::FileHandlersInfo& file_handlers_info);
// Creates shortcuts for an app. This loads the app's icon from disk, and calls
// CreateShortcutsWithInfo(). If you already have a ShortcutInfo with the app's

Powered by Google App Engine
This is Rietveld 408576698