Reland: Fix crash when the source browser window is deleted during a drag

Fix crash when the source browser window is deleted during a drag

This CL makes Widget::RunShellDrag() and DesktopDragDropClientWin not crash if
the browser window is deleted during a drag-drop operation. An extension can
delete the browser window during the drag-drop operation.

BUG=440534
TEST=BookmarkBarViewTest22.*
R=pkasting
TBR=sky (The files in ui/views/widget are identical to the original CL)

Committed: https://crrev.com/6b8237f513dc4cd044ff117fc12ee9178b4562e8
Cr-Commit-Position: refs/heads/master@{#309484}

[pkotwicz, 2014-12-22 15:25:14]

pkotwicz@chromium.org changed reviewers:
+ avi@chromium.org

[pkotwicz, 2014-12-22 15:25:14]

Avi, can you please take a look? (I am adding you as a reviewer because the
change to reland this CL is in chrome/browser)

Patch set #1 has the CL as it landed in
https://codereview.chromium.org/795303002/

In patch set #1, I reenabled some tests on ChromeOS which I should not have
done. I will do that in a separate CL. It also looks like those tests pass on
X11 ChromeOS but not ozone ChromeOS.

[pkotwicz, 2014-12-22 15:26:51]

pkotwicz@chromium.org changed reviewers:
- avi@chromium.org

[Avi (use Gerrit), 2014-12-22 15:27:44]

avi@chromium.org changed reviewers:
+ avi@chromium.org

[Avi (use Gerrit), 2014-12-22 15:27:45]

This looks good, but I'm not an owner for chrome/browser so my LGTM won't help.
I reverted it because the tree was red, but I have no idea how Views works.

[pkotwicz, 2014-12-22 15:31:37]

pkotwicz@chromium.org changed reviewers:
+ pkasting@chromium.org

[pkotwicz, 2014-12-22 15:31:38]

pkasting@, can you please take a look? (I am adding you as a reviewer because
the
change to reland this CL is in chrome/browser/ui/views)

Patch set #1 has the CL as it landed in
https://codereview.chromium.org/795303002/

In patch set #1, I reenabled some tests on ChromeOS which I should not have
done. I will do that in a separate CL. It also looks like those tests pass on
X11 ChromeOS but not ozone ChromeOS.

[Peter Kasting, 2014-12-22 21:31:09]

c/b/ui LGTM

https://codereview.chromium.org/819793002/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc (right):

https://codereview.chromium.org/819793002/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc:2009:
ui_test_utils::MoveMouseToCenterAndPress(button, ui_controls::LEFT,
Nit: All lines of args should align their start positions (in this case, by
breaking after '(')  (3 places)

https://codereview.chromium.org/819793002/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc:2018:
ASSERT_TRUE(menu != NULL);
Nit: "!= NULL" unnecessary, and we're trying to eliminate NULL in favor of
nullptr anyway.  (2 places)

https://codereview.chromium.org/819793002/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc:2041: // See comment
above this method as to why we do this.
What comment?

[pkotwicz, 2014-12-22 22:14:31]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-12-22 22:15:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/819793002/40001

[commit-bot: I haz the power, 2014-12-22 22:23:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-22 22:23:18]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pkotwicz, 2014-12-22 23:02:36]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-12-22 23:03:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/819793002/40001

[commit-bot: I haz the power, 2014-12-22 23:28:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-22 23:29:11]

Patchset 3 (id:??) landed as
https://crrev.com/6b8237f513dc4cd044ff117fc12ee9178b4562e8
Cr-Commit-Position: refs/heads/master@{#309484}