Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 819703002: win: Avoid signed/unsigned warning (Closed)

Created:
6 years ago by scottmg
Modified:
6 years ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

win: Avoid signed/unsigned warning d:\src\crashpad\crashpad\snapshot\cpu_context.cc(96) : warning C4245: 'return' : conversion from 'int' to 'uint64_t', signed/unsigned mismatch R=mark@chromium.org BUG=crashpad:1 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/8d7681752d717137da2d892734e7cc455de31c6f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M snapshot/cpu_context.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
6 years ago (2014-12-19 22:19:48 UTC) #1
Mark Mentovai
LGTM
6 years ago (2014-12-19 22:50:28 UTC) #2
scottmg
6 years ago (2014-12-19 22:53:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8d7681752d717137da2d892734e7cc455de31c6f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698