Reset the loading frame count (etc) when starting a new main frame navigation.

Reset the loading frame count (etc) when starting a new main frame navigation.

Previously it was possible for the count to always stay non-zero if a new
navigation interrupted an earlier one.

BUG=429399
TEST=Navigate to a new page after DidChangeLoadProgress, before DidStopLoading.

Committed: https://crrev.com/1163acfc7d95c86d427cefd5273f5d80ff253d87
Cr-Commit-Position: refs/heads/master@{#309263}

[Charlie Reis, 2014-12-19 19:47:48]

creis@chromium.org changed reviewers:
+ avi@chromium.org

[Charlie Reis, 2014-12-19 19:47:48]

Avi, can you take a look?

(CC Nasko for FYI.)

https://codereview.chromium.org/819673002/diff/1/content/browser/web_contents...
File content/browser/web_contents/web_contents_impl.cc (right):

https://codereview.chromium.org/819673002/diff/1/content/browser/web_contents...
content/browser/web_contents/web_contents_impl.cc:2743:
loading_frames_in_progress_ = 0;
Note: I didn't put this line inside ResetLoadProgressState because that would
have affected OnDidStopLoading's behavior.

https://codereview.chromium.org/819673002/diff/1/content/browser/web_contents...
File content/browser/web_contents/web_contents_impl_browsertest.cc (right):

https://codereview.chromium.org/819673002/diff/1/content/browser/web_contents...
content/browser/web_contents/web_contents_impl_browsertest.cc:541:
IN_PROC_BROWSER_TEST_F(WebContentsImplBrowserTest, LoadProgressWithFrames) {
I added this to complement the LoadProgress test above, since it seemed like we
should have coverage of a case with multiple frames.

[Avi (use Gerrit), 2014-12-19 19:54:54]

lgtm

https://codereview.chromium.org/819673002/diff/1/content/browser/web_contents...
File content/browser/web_contents/web_contents_impl.cc (right):

https://codereview.chromium.org/819673002/diff/1/content/browser/web_contents...
content/browser/web_contents/web_contents_impl.cc:2743:
loading_frames_in_progress_ = 0;
On 2014/12/19 19:47:48, Charlie Reis (OOO until Jan 5) wrote:
> Note: I didn't put this line inside ResetLoadProgressState because that would
> have affected OnDidStopLoading's behavior.

Acknowledged.

[Charlie Reis, 2014-12-19 19:59:18]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2014-12-19 20:00:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/819673002/1

[commit-bot: I haz the power, 2014-12-19 21:19:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-19 21:20:04]

Patchset 1 (id:??) landed as
https://crrev.com/1163acfc7d95c86d427cefd5273f5d80ff253d87
Cr-Commit-Position: refs/heads/master@{#309263}