Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 819643006: Revert of Add explicit support for discovering the GpuProcess to Telemetry's 'Model'. (Closed)

Created:
5 years, 11 months ago by Ryan Hamilton
Modified:
5 years, 11 months ago
CC:
chromium-reviews, tfarina, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add explicit support for discovering the GpuProcess to Telemetry's 'Model'. (patchset #1 id:1 of https://codereview.chromium.org/816833006/) Reason for revert: Since this CL landed, we've been seeing flakes in Mac 10.9 telemetry_unittests. It's not clear that this CL is responsible, but the timing is suspicious. Recent 10.9 failures: https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20(dbg) Detailed log: https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/1965/steps/telemetry_unittests/logs/stdio Original issue's description: > Add explicit support for discovering the GpuProcess to Telemetry's 'Model'. > > BUG= > > Committed: https://crrev.com/f6ade006723de6a100b6dd6b545cb5916b197925 > Cr-Commit-Position: refs/heads/master@{#311486} TBR=skyostil@chromium.org,tonyg@chromium.org,andrewhayden@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/8bb2a47135a731b12116feb832a9dc6433729fa2 Cr-Commit-Position: refs/heads/master@{#311592}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M tools/telemetry/telemetry/timeline/model.py View 2 chunks +0 lines, -11 lines 0 comments Download
M tools/telemetry/telemetry/timeline/trace_event_importer.py View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ryan Hamilton
Created Revert of Add explicit support for discovering the GpuProcess to Telemetry's 'Model'.
5 years, 11 months ago (2015-01-15 00:44:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/819643006/1
5 years, 11 months ago (2015-01-15 00:44:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 00:45:30 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8bb2a47135a731b12116feb832a9dc6433729fa2 Cr-Commit-Position: refs/heads/master@{#311592}
5 years, 11 months ago (2015-01-15 00:48:26 UTC) #4
Andrew Hayden (chromium.org)
On 2015/01/15 00:48:26, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
5 years, 11 months ago (2015-01-15 08:54:46 UTC) #5
Sami
On 2015/01/15 08:54:46, Andrew Hayden wrote: > On 2015/01/15 00:48:26, I haz the power (commit-bot) ...
5 years, 11 months ago (2015-01-15 10:37:43 UTC) #6
Andrew Hayden (chromium.org)
5 years, 11 months ago (2015-01-15 10:56:58 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/847433005/ by andrewhayden@chromium.org.

The reason for reverting is: Per discussion with owner (skyostil@) and analysis
of subsequent flakes that continued to demonstrate the reported problem after
the revert, we've concluded that the original change is not responsible for the
flakes. Reverting the revert..

Powered by Google App Engine
This is Rietveld 408576698