Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 819633002: Rearanged imports of custom Polymer elements in OOBE. (Closed)

Created:
6 years ago by dzhioev (left Google)
Modified:
6 years ago
Reviewers:
ygorshenin1
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rearanged imports of custom Polymer elements in OOBE. This is a preliminary CL for upcoming Polymer update. BUG=440039 TEST=manually, hotrod pairing works Committed: https://crrev.com/787bcbaeaf3c24231896add10d1e955aff8d9692 Cr-Commit-Position: refs/heads/master@{#309446}

Patch Set 1 #

Patch Set 2 : #

Total comments: 14

Patch Set 3 : Nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -439 lines) Patch
A + chrome/browser/resources/chromeos/login/controller-pairing-screen.html View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
A + chrome/browser/resources/chromeos/login/controller-pairing-screen.js View 1 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/resources/chromeos/login/custom_elements.html View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/custom_elements.js View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A + chrome/browser/resources/chromeos/login/host-pairing-screen.html View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
A + chrome/browser/resources/chromeos/login/host-pairing-screen.js View 1 2 2 chunks +0 lines, -24 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_controller_pairing.html View 1 2 1 chunk +0 lines, -219 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_controller_pairing.js View 1 chunk +0 lines, -75 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_host_pairing.html View 1 2 1 chunk +0 lines, -79 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_host_pairing.js View 1 2 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dzhioev (left Google)
PTAL
6 years ago (2014-12-19 14:11:11 UTC) #2
ygorshenin1
lgtm https://codereview.chromium.org/819633002/diff/20001/chrome/browser/resources/chromeos/login/controller-pairing-screen.html File chrome/browser/resources/chromeos/login/controller-pairing-screen.html (right): https://codereview.chromium.org/819633002/diff/20001/chrome/browser/resources/chromeos/login/controller-pairing-screen.html#newcode218 chrome/browser/resources/chromeos/login/controller-pairing-screen.html:218: nit: could you please remove blank line #218? ...
6 years ago (2014-12-22 16:48:58 UTC) #3
dzhioev (left Google)
https://codereview.chromium.org/819633002/diff/20001/chrome/browser/resources/chromeos/login/controller-pairing-screen.html File chrome/browser/resources/chromeos/login/controller-pairing-screen.html (right): https://codereview.chromium.org/819633002/diff/20001/chrome/browser/resources/chromeos/login/controller-pairing-screen.html#newcode218 chrome/browser/resources/chromeos/login/controller-pairing-screen.html:218: On 2014/12/22 16:48:58, ygorshenin1 wrote: > nit: could you ...
6 years ago (2014-12-22 17:48:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/819633002/40001
6 years ago (2014-12-22 17:50:00 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-22 19:19:24 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-22 19:20:08 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/787bcbaeaf3c24231896add10d1e955aff8d9692
Cr-Commit-Position: refs/heads/master@{#309446}

Powered by Google App Engine
This is Rietveld 408576698