Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 819623002: Enable Blink Scheduler (but not for WebView or ChromeOS) (Closed)

Created:
6 years ago by alex clarke (OOO till 29th)
Modified:
6 years ago
Reviewers:
mnaganov (inactive), rmcilroy, mnaganov
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, scheduler-bugs_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable Blink Scheduler, but not for WebView or ChromeOS because there are some tests failing there (see 1 & 2). Fixing these may take some time and we're keen to gather performance metrics over the Christmas period. We'll fix the WebView or ChromeOS problems in the new year. ATTN Sheriffs: This patch will expose flakiness in css3/filters/effect-reference-rename.html there is a patch in review to fix that: https://codereview.chromium.org/787563003 [1] http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/39248 [2] http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/9441 BUG=432129, 444572, 444574 Committed: https://crrev.com/bb1bc3798d749cadd67d21d80c93412f2dd09bcb Cr-Commit-Position: refs/heads/master@{#309435}

Patch Set 1 #

Patch Set 2 : Minor change #

Patch Set 3 : More like Ross's approach #

Patch Set 4 : Use a hammer: turn off scheduler tests for now #

Patch Set 5 : Ross's solution #

Patch Set 6 : Try something simple #

Patch Set 7 : Try with scheduler off #

Patch Set 8 : Just disable it where it doesn't work #

Total comments: 4

Patch Set 9 : Link bugs as requested. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M android_webview/lib/main/aw_main_delegate.cc View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/scheduler/renderer_scheduler.cc View 1 2 3 4 5 6 7 8 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
alex clarke (OOO till 29th)
6 years ago (2014-12-22 15:28:56 UTC) #2
alex clarke (OOO till 29th)
6 years ago (2014-12-22 15:42:37 UTC) #4
mnaganov (inactive)
lgtm
6 years ago (2014-12-22 15:44:04 UTC) #6
mnaganov (inactive)
lgtm
6 years ago (2014-12-22 15:44:05 UTC) #7
rmcilroy
Lgtm (with nits). Thanks Alex. https://codereview.chromium.org/819623002/diff/130001/android_webview/lib/main/aw_main_delegate.cc File android_webview/lib/main/aw_main_delegate.cc (right): https://codereview.chromium.org/819623002/diff/130001/android_webview/lib/main/aw_main_delegate.cc#newcode85 android_webview/lib/main/aw_main_delegate.cc:85: // FIXME: A couple ...
6 years ago (2014-12-22 15:58:05 UTC) #8
alex clarke (OOO till 29th)
https://codereview.chromium.org/819623002/diff/130001/android_webview/lib/main/aw_main_delegate.cc File android_webview/lib/main/aw_main_delegate.cc (right): https://codereview.chromium.org/819623002/diff/130001/android_webview/lib/main/aw_main_delegate.cc#newcode85 android_webview/lib/main/aw_main_delegate.cc:85: // FIXME: A couple of tests fail with the ...
6 years ago (2014-12-22 16:28:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/819623002/150001
6 years ago (2014-12-22 16:28:32 UTC) #11
commit-bot: I haz the power
Committed patchset #9 (id:150001)
6 years ago (2014-12-22 17:23:17 UTC) #12
commit-bot: I haz the power
6 years ago (2014-12-22 17:25:11 UTC) #13
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/bb1bc3798d749cadd67d21d80c93412f2dd09bcb
Cr-Commit-Position: refs/heads/master@{#309435}

Powered by Google App Engine
This is Rietveld 408576698