Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 819613002: Improved --trace-opt output a bit. (Closed)

Created:
6 years ago by Sven Panne
Modified:
6 years ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Improved --trace-opt output a bit. This ensures that we always have a kind of "brace" around the actual compilation with --trace-opt. Previously this was coupled to --trace-hydrogen for Crankshaft, and there was no output at the start of the compilation for TurboFan. Removed redundant "[completed...]" output: Whenever the compilation was successful, we have already printed "[optimizing...took...]". Output total TurboFanning time with --trace-opt, too (basically as graph building time, this is rather arbitrary). R=bmeurer@chromium.org Committed: https://crrev.com/50b7ca5593b454e923c9f4707dc45322f9a39ef9 Cr-Commit-Position: refs/heads/master@{#25900}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M src/compiler.cc View 1 3 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Sven Panne
6 years ago (2014-12-19 11:41:28 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/819613002/diff/1/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/819613002/diff/1/src/compiler.cc#newcode434 src/compiler.cc:434: << " using hydrogen]" << std::endl; "using CrankShaft" for ...
6 years ago (2014-12-19 11:42:13 UTC) #3
Sven Panne
https://codereview.chromium.org/819613002/diff/1/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/819613002/diff/1/src/compiler.cc#newcode434 src/compiler.cc:434: << " using hydrogen]" << std::endl; On 2014/12/19 11:42:13, ...
6 years ago (2014-12-19 11:46:54 UTC) #4
Benedikt Meurer
lgtm
6 years ago (2014-12-19 11:47:04 UTC) #6
Sven Panne
Committed patchset #2 (id:20001) manually as 50b7ca5593b454e923c9f4707dc45322f9a39ef9 (presubmit successful).
6 years ago (2014-12-19 11:47:34 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-19 11:47:40 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/50b7ca5593b454e923c9f4707dc45322f9a39ef9
Cr-Commit-Position: refs/heads/master@{#25900}

Powered by Google App Engine
This is Rietveld 408576698