Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 819583004: Elim device log spam when translating ONC (Closed)

Created:
5 years, 11 months ago by stevenjb
Modified:
5 years, 11 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_portal_detect_shutdown_crash
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Elim device log spam when translating ONC This also updates the logging in shiil_property_util to use device_event_log.h. TBR=isherman@chromium.org for trivial change BUG=none Committed: https://crrev.com/d432c0eb6c8f6fd27b6d210701df47317d480e05 Cr-Commit-Position: refs/heads/master@{#312937}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -39 lines) Patch
M chromeos/network/onc/onc_translator_shill_to_onc.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/shill_property_util.h View 1 chunk +5 lines, -2 lines 0 comments Download
M chromeos/network/shill_property_util.cc View 10 chunks +29 lines, -34 lines 0 comments Download
M components/metrics/net/wifi_access_point_info_provider_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
stevenjb
5 years, 11 months ago (2015-01-22 19:42:14 UTC) #2
pneubeck (no reviews)
lgtm
5 years, 11 months ago (2015-01-22 20:09:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/819583004/20001
5 years, 11 months ago (2015-01-23 21:02:11 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-23 21:54:46 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 21:55:39 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d432c0eb6c8f6fd27b6d210701df47317d480e05
Cr-Commit-Position: refs/heads/master@{#312937}

Powered by Google App Engine
This is Rietveld 408576698