Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2352)

Unified Diff: content/test/webrtc_audio_device_test.cc

Issue 81953002: Remove MockMediaInternals and incestuous usage. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Polish. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/webrtc_audio_device_test.cc
diff --git a/content/test/webrtc_audio_device_test.cc b/content/test/webrtc_audio_device_test.cc
index 605713acda3dd17ae398f597820fb7926b05ed31..6237cfae71ad0505a6cbe734686ea02f004b8582 100644
--- a/content/test/webrtc_audio_device_test.cc
+++ b/content/test/webrtc_audio_device_test.cc
@@ -284,7 +284,7 @@ void MAYBE_WebRTCAudioDeviceTest::InitializeIOThread(const char* thread_name) {
MockRTCResourceContext* resource_context =
static_cast<MockRTCResourceContext*>(resource_context_.get());
resource_context->set_request_context(test_request_context_.get());
- media_internals_.reset(new MockMediaInternals());
+ media_internals_ = MediaInternals::GetInstance();
// Create our own AudioManager, AudioMirroringManager and MediaStreamManager.
audio_manager_.reset(media::AudioManager::Create());
@@ -319,7 +319,7 @@ void MAYBE_WebRTCAudioDeviceTest::CreateChannel(const char* name) {
static const int kRenderProcessId = 1;
audio_render_host_ = new TestAudioRendererHost(
kRenderProcessId, audio_manager_.get(), mirroring_manager_.get(),
- media_internals_.get(), media_stream_manager_.get(), channel_.get());
+ media_internals_, media_stream_manager_.get(), channel_.get());
acolwell GONE FROM CHROMIUM 2013/11/22 19:12:48 This appears to be the only use of media_internals
DaleCurtis 2013/11/22 20:33:33 Done.
audio_render_host_->set_peer_pid_for_testing(base::GetCurrentProcId());
audio_input_renderer_host_ =
« content/test/webrtc_audio_device_test.h ('K') | « content/test/webrtc_audio_device_test.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698