Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: Source/core/loader/DocumentThreadableLoader.cpp

Issue 819513004: Remove wrong ASSERT on request instance for fallback in DocumentThreadableLoader (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/DocumentThreadableLoader.cpp
diff --git a/Source/core/loader/DocumentThreadableLoader.cpp b/Source/core/loader/DocumentThreadableLoader.cpp
index 3c7ac1ba4338c819d01683ff92e5acd1a0f3dcb9..012a25c242827bc19a580f40d5232a8431183479 100644
--- a/Source/core/loader/DocumentThreadableLoader.cpp
+++ b/Source/core/loader/DocumentThreadableLoader.cpp
@@ -419,7 +419,11 @@ void DocumentThreadableLoader::handleResponse(unsigned long identifier, const Re
return;
}
- ASSERT(!m_fallbackRequestForServiceWorker);
+ // Here, it's possible that |m_fallbackRequestForServiceWorker| is set.
+ // This means the document was controlled by the ServiceWorker but the
+ // browser process didn't forward the request to the ServiceWorker for
+ // some reason.
+ m_fallbackRequestForServiceWorker = nullptr;
if (!m_sameOriginRequest && m_options.crossOriginRequestPolicy == UseAccessControl) {
String accessControlErrorDescription;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698