Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 819483002: CloseMultipleNowOrOnExec(): promote out of test (Closed)

Created:
6 years ago by Mark Mentovai
Modified:
6 years ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

CloseMultipleNowOrOnExec(): promote out of test. This function will be useful in upcoming non-test code. Because the first Crashpad client that wants a Crashpad handler will now be responsible for starting the handler process, this will prevent file descriptors from leaking to the handler process. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/110eafe9a17acb9e4a6419aec1d139075edf0c16

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -209 lines) Patch
A + util/posix/close_multiple.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + util/posix/close_multiple.cc View 1 chunk +1 line, -1 line 0 comments Download
M util/test/multiprocess_exec.cc View 1 chunk +1 line, -1 line 0 comments Download
D util/test/posix/close_multiple.h View 1 chunk +0 lines, -44 lines 0 comments Download
D util/test/posix/close_multiple.cc View 1 chunk +0 lines, -158 lines 0 comments Download
M util/util.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
For reference, the handler-starter I’m working on is in https://codereview.chromium.org/798743003/, along with the crashpad_handler process ...
6 years ago (2014-12-18 20:46:06 UTC) #2
Robert Sesek
LGTM
6 years ago (2014-12-19 19:25:39 UTC) #3
Mark Mentovai
6 years ago (2014-12-19 21:42:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
110eafe9a17acb9e4a6419aec1d139075edf0c16 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698