Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 819473004: Set up the nginx servers for handling *.skia.org traffic. (Closed)

Created:
5 years, 11 months ago by jcgregorio
Modified:
5 years, 11 months ago
Reviewers:
stephana, rmistry
CC:
reviews_skia.org, tfarina
Base URL:
https://skia.googlesource.com/buildbot@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Set up the nginx servers for handling *.skia.org traffic. Note that for now we use *.skiadev.org, which is just a placeholder until we get *.skia.org DNS entries straightened out. Note that this doesn't have SSL certs which will also have to wait until after the *.skia.org DNS change is done. stepahan - for the nginx config. rmistry - for the rest of the files. You can see this live at skiadev.org and perf.skiadev.org. See also the READM.md file for the design of the traffic handling. BUG=skia: Committed: https://skia.googlesource.com/buildbot/+/783a3c45917b4c9b9823e4cb91987d7c5d623f8e

Patch Set 1 #

Patch Set 2 : readme #

Patch Set 3 : readme #

Total comments: 2

Patch Set 4 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -5 lines) Patch
A + compute_engine_scripts/skfe/startup-script.sh View 1 chunk +1 line, -1 line 0 comments Download
A + compute_engine_scripts/skfe/vm_config.sh View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A compute_engine_scripts/skfe/vm_create_instance.sh View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
A compute_engine_scripts/skfe/vm_delete_instance.sh View 1 chunk +17 lines, -0 lines 0 comments Download
M push/skiapush.conf View 1 chunk +14 lines, -0 lines 0 comments Download
A skfe/README.md View 1 2 1 chunk +45 lines, -0 lines 0 comments Download
A skfe/build_release View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
A skfe/sys/nginx_monit View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
A skfe/sys/skia_org View 1 2 3 1 chunk +84 lines, -0 lines 4 comments Download

Messages

Total messages: 10 (2 generated)
jcgregorio
5 years, 11 months ago (2015-01-05 16:02:44 UTC) #2
stephana
On 2015/01/05 16:02:44, jcgregorio wrote: lgtm
5 years, 11 months ago (2015-01-05 16:09:29 UTC) #3
rmistry
LGTM https://codereview.chromium.org/819473004/diff/40001/compute_engine_scripts/skfe/vm_create_instance.sh File compute_engine_scripts/skfe/vm_create_instance.sh (right): https://codereview.chromium.org/819473004/diff/40001/compute_engine_scripts/skfe/vm_create_instance.sh#newcode19 compute_engine_scripts/skfe/vm_create_instance.sh:19: --machine-type n1-standard-4 \ Store machine type in vm_config.sh ...
5 years, 11 months ago (2015-01-05 19:25:34 UTC) #4
jcgregorio
https://codereview.chromium.org/819473004/diff/40001/compute_engine_scripts/skfe/vm_create_instance.sh File compute_engine_scripts/skfe/vm_create_instance.sh (right): https://codereview.chromium.org/819473004/diff/40001/compute_engine_scripts/skfe/vm_create_instance.sh#newcode19 compute_engine_scripts/skfe/vm_create_instance.sh:19: --machine-type n1-standard-4 \ On 2015/01/05 19:25:34, rmistry wrote: > ...
5 years, 11 months ago (2015-01-05 20:13:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/819473004/60001
5 years, 11 months ago (2015-01-05 20:13:42 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://skia.googlesource.com/buildbot/+/783a3c45917b4c9b9823e4cb91987d7c5d623f8e
5 years, 11 months ago (2015-01-05 20:13:50 UTC) #8
tfarina
https://codereview.chromium.org/819473004/diff/60001/skfe/sys/skia_org File skfe/sys/skia_org (right): https://codereview.chromium.org/819473004/diff/60001/skfe/sys/skia_org#newcode3 skfe/sys/skia_org:3: server_name skiadev.org www.skiadev.org; do we need access_log and error_log? ...
5 years, 11 months ago (2015-01-10 18:28:52 UTC) #9
jcgregorio
5 years, 11 months ago (2015-01-12 12:25:03 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/819473004/diff/60001/skfe/sys/skia_org
File skfe/sys/skia_org (right):

https://codereview.chromium.org/819473004/diff/60001/skfe/sys/skia_org#newcode3
skfe/sys/skia_org:3: server_name skiadev.org www.skiadev.org;
On 2015/01/10 18:28:52, tfarina wrote:
> do we need access_log and error_log?

The default behavior is fine.

https://codereview.chromium.org/819473004/diff/60001/skfe/sys/skia_org#newcode4
skfe/sys/skia_org:4: 
On 2015/01/10 18:28:52, tfarina wrote:
> where is the ssl protection configuration? I know port 80 is for http. I'm
just
> curious to know where the 443 is handled now.

SSL config will be done later once these servers start handling skia.org
traffic.

Powered by Google App Engine
This is Rietveld 408576698