Implement RevokePermission() method in PermissionService.

chrome/browser/content_settings/permission_context_base_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/content_settings/permission_context_base.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "chrome/browser/content_settings/permission_queue_controller.h"
 #include "chrome/browser/infobars/infobar_service.h"
@@ skipping 103 matching lines @@
 
     RespondToPermission(&permission_context, id, url, true);
     EXPECT_TRUE(permission_context.permission_set());
     EXPECT_TRUE(permission_context.permission_granted());
     EXPECT_TRUE(permission_context.tab_context_updated());
 
     ContentSetting setting =
         profile()->GetHostContentSettingsMap()->GetContentSetting(
             url.GetOrigin(), url.GetOrigin(),
             CONTENT_SETTINGS_TYPE_NOTIFICATIONS, std::string());
-    EXPECT_EQ(CONTENT_SETTING_ALLOW , setting);
+    EXPECT_EQ(CONTENT_SETTING_ALLOW, setting);
   }
 
   void TestAskAndDismiss_TestContent() {
     TestPermissionContext permission_context(
         profile(), CONTENT_SETTINGS_TYPE_MIDI_SYSEX);
     GURL url("http://www.google.es");
     content::WebContentsTester::For(web_contents())->NavigateAndCommit(url);
 
     const PermissionRequestID id(
         web_contents()->GetRenderProcessHost()->GetID(),
         web_contents()->GetRenderViewHost()->GetRoutingID(),
         -1, GURL());
     permission_context.RequestPermission(
         web_contents(),
         id, url, true,
         base::Bind(&TestPermissionContext::TrackPermissionDecision,
                    base::Unretained(&permission_context)));
 
     RespondToPermission(&permission_context, id, url, false);
     EXPECT_TRUE(permission_context.permission_set());
     EXPECT_FALSE(permission_context.permission_granted());
     EXPECT_TRUE(permission_context.tab_context_updated());
 
     ContentSetting setting =
         profile()->GetHostContentSettingsMap()->GetContentSetting(
             url.GetOrigin(), url.GetOrigin(),
             CONTENT_SETTINGS_TYPE_MIDI_SYSEX, std::string());
-    EXPECT_EQ(CONTENT_SETTING_ASK , setting);
+    EXPECT_EQ(CONTENT_SETTING_ASK, setting);
   }
 
   void TestRequestPermissionInvalidUrl(ContentSettingsType type) {
     TestPermissionContext permission_context(profile(), type);
     GURL url;
     ASSERT_FALSE(url.is_valid());
     content::WebContentsTester::For(web_contents())->NavigateAndCommit(url);
 
     const PermissionRequestID id(
         web_contents()->GetRenderProcessHost()->GetID(),
         web_contents()->GetRenderViewHost()->GetRoutingID(),
         -1, GURL());
     permission_context.RequestPermission(
         web_contents(),
         id, url, true,
         base::Bind(&TestPermissionContext::TrackPermissionDecision,
                    base::Unretained(&permission_context)));
 
     EXPECT_TRUE(permission_context.permission_set());
     EXPECT_FALSE(permission_context.permission_granted());
     EXPECT_TRUE(permission_context.tab_context_updated());
 
     ContentSetting setting =
         profile()->GetHostContentSettingsMap()->GetContentSetting(
             url.GetOrigin(), url.GetOrigin(), type, std::string());
     EXPECT_EQ(CONTENT_SETTING_ASK, setting);
   }
 
+  void TestGrantAndRevoke_TestContent(ContentSettingsType type,
+                                      ContentSetting expected_default) {
+    TestPermissionContext permission_context(profile(), type);
+    GURL url("http://www.google.com");
+    content::WebContentsTester::For(web_contents())->NavigateAndCommit(url);
+
+    const PermissionRequestID id(
+        web_contents()->GetRenderProcessHost()->GetID(),
+        web_contents()->GetRenderViewHost()->GetRoutingID(),
+        -1, GURL());
+    permission_context.RequestPermission(
+        web_contents(),
+        id, url, true,
+        base::Bind(&TestPermissionContext::TrackPermissionDecision,
+                   base::Unretained(&permission_context)));
+
+    RespondToPermission(&permission_context, id, url, true);
+    EXPECT_TRUE(permission_context.permission_set());
+    EXPECT_TRUE(permission_context.permission_granted());
+    EXPECT_TRUE(permission_context.tab_context_updated());
+
+    ContentSetting setting =
+        profile()->GetHostContentSettingsMap()->GetContentSetting(
+            url.GetOrigin(), url.GetOrigin(),
+            type, std::string());
+    EXPECT_EQ(CONTENT_SETTING_ALLOW, setting);
+
+    // Try to reset permission.
+    permission_context.ResetPermission(url.GetOrigin(), url.GetOrigin());
+    ContentSetting setting_after_reset =
+        profile()->GetHostContentSettingsMap()->GetContentSetting(
+            url.GetOrigin(), url.GetOrigin(),
+            type, std::string());
+    ContentSetting default_setting =
+        profile()->GetHostContentSettingsMap()->GetDefaultContentSetting(
+            type, nullptr);
+    EXPECT_EQ(default_setting, setting_after_reset);
+  }
+
  private:
   // ChromeRenderViewHostTestHarness:
   void SetUp() override {
     ChromeRenderViewHostTestHarness::SetUp();
     InfoBarService::CreateForWebContents(web_contents());
     PermissionBubbleManager::CreateForWebContents(web_contents());
   }
 
   DISALLOW_COPY_AND_ASSIGN(PermissionContextBaseTests);
 };
@@ skipping 19 matching lines @@
 TEST_F(PermissionContextBaseTests, TestNonValidRequestingUrl) {
   TestRequestPermissionInvalidUrl(CONTENT_SETTINGS_TYPE_GEOLOCATION);
   TestRequestPermissionInvalidUrl(CONTENT_SETTINGS_TYPE_NOTIFICATIONS);
   TestRequestPermissionInvalidUrl(CONTENT_SETTINGS_TYPE_MIDI_SYSEX);
   TestRequestPermissionInvalidUrl(CONTENT_SETTINGS_TYPE_PUSH_MESSAGING);
 #if defined(OS_ANDROID) || defined(OS_CHROMEOS)
   TestRequestPermissionInvalidUrl(
       CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER);
 #endif
 }
+
+// Simulates granting and revoking of permissions.
+TEST_F(PermissionContextBaseTests, TestGrantAndRevoke) {
+  TestGrantAndRevoke_TestContent(CONTENT_SETTINGS_TYPE_GEOLOCATION,
+                                 CONTENT_SETTING_ASK);
+  // TODO(timvolodine): notification permissions seem to work differently with
+  // infobars and bubbles (crbug.com/453784).
+  TestGrantAndRevoke_TestContent(CONTENT_SETTINGS_TYPE_MIDI_SYSEX,
+                                 CONTENT_SETTING_ASK);
+  // TODO(timvolodine): infobars does not seem to implement push messaging
+  // permissions (crbug.com/453788).
+#if defined(OS_ANDROID)
+  TestGrantAndRevoke_TestContent(
+      CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER, CONTENT_SETTING_ASK);
+#endif
+}
+
+// Simulates granting and revoking of permissions using permission bubbles.
+TEST_F(PermissionContextBaseTests, TestGrantAndRevokeWithBubbles) {
+  StartUsingPermissionBubble();
+  TestGrantAndRevoke_TestContent(CONTENT_SETTINGS_TYPE_GEOLOCATION,
+                                 CONTENT_SETTING_ASK);
+#if defined(ENABLE_NOTIFICATIONS)
+  TestGrantAndRevoke_TestContent(CONTENT_SETTINGS_TYPE_NOTIFICATIONS,
+                                 CONTENT_SETTING_ASK);
+#endif
+  TestGrantAndRevoke_TestContent(CONTENT_SETTINGS_TYPE_MIDI_SYSEX,
+                                 CONTENT_SETTING_ASK);
+  TestGrantAndRevoke_TestContent(CONTENT_SETTINGS_TYPE_PUSH_MESSAGING,
+                                 CONTENT_SETTING_ASK);
+#if defined(OS_ANDROID)

[Nico, 2015/01/30 17:32:34]

This is the same TODO as in the previous test, right? If so, lgtm.

[timvolodine, 2015/02/02 12:25:54]

those todo's are for the infobar related tests, I've put them together at the
end with a bit more explanation.

+  TestGrantAndRevoke_TestContent(
+      CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER, CONTENT_SETTING_ASK);
+#endif
+}