Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: chrome/browser/captive_portal/captive_portal_browsertest.cc

Issue 819443003: Add finch gate for captive portal interstitial. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit tests Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ssl/ssl_error_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/captive_portal/captive_portal_browsertest.cc
diff --git a/chrome/browser/captive_portal/captive_portal_browsertest.cc b/chrome/browser/captive_portal/captive_portal_browsertest.cc
index 1fcb08c4ee4c0b51930d8a5b1a4682fcf33a6192..d128f938b51bc9505616a2b5b76a3748245ff3d6 100644
--- a/chrome/browser/captive_portal/captive_portal_browsertest.cc
+++ b/chrome/browser/captive_portal/captive_portal_browsertest.cc
@@ -905,6 +905,7 @@ class CaptivePortalBrowserTest : public InProcessBrowserTest {
// InProcessBrowserTest:
void SetUpOnMainThread() override;
void TearDownOnMainThread() override;
+ void SetUpCommandLine(base::CommandLine* command_line) override;
// Sets the captive portal checking preference. Does not affect the command
// line flag, which is set in SetUpCommandLine.
@@ -1118,6 +1119,13 @@ void CaptivePortalBrowserTest::TearDownOnMainThread() {
EXPECT_FALSE(CheckPending(browser()));
}
+void CaptivePortalBrowserTest::SetUpCommandLine(
+ base::CommandLine* command_line) {
+ // Enable finch experiment for captive portal interstitials.
+ command_line->AppendSwitchASCII(
+ switches::kForceFieldTrials, "CaptivePortalInterstitial/Enabled/");
+}
+
void CaptivePortalBrowserTest::EnableCaptivePortalDetection(
Profile* profile, bool enabled) {
profile->GetPrefs()->SetBoolean(prefs::kAlternateErrorPagesEnabled, enabled);
« no previous file with comments | « no previous file | chrome/browser/ssl/ssl_error_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698