Issue 8194005: Relanding: Add js api for hosted/packaged apps to request notification authorization

Issue 8194005: Relanding: Add js api for hosted/packaged apps to request notification authorization (Closed)

Created:
9 years, 2 months ago by asargent_no_longer_on_chrome

Modified:
9 years, 2 months ago

Reviewers:
commit-bot: I haz the power

CC:
chromium-reviews, Erik does not do reviews, Paweł Hajdan Jr., mihaip+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Relanding: Add js api for hosted/packaged apps to request notification authorization (this time with fixed unit test) BUG=98145 TEST=None (more pieces will be landing that will make it testable) TBR=aa@chromium.org Original Review URL: http://codereview.chromium.org/8113006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104410 0039d316-1c4b-4281-b951-d872f2087c98 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104438

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+470 lines, -60 lines)			Patch
A	chrome/browser/extensions/app_notify_channel_setup.h	View	1 chunk	+52 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/app_notify_channel_setup.cc	View	1 chunk	+49 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/app_notify_channel_setup_unittest.cc	View	1 chunk	+78 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_tab_helper.h	View	4 chunks	+18 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/extension_tab_helper.cc	View	3 chunks	+45 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_renderer.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions/extension_messages.h	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	chrome/renderer/extensions/chrome_app_bindings.h	View	3 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/renderer/extensions/chrome_app_bindings.cc	View	6 chunks	+75 lines, -0 lines	0 comments	Download
M	chrome/renderer/extensions/chrome_webstore_bindings.cc	View	5 chunks	+12 lines, -51 lines	0 comments	Download
M	chrome/renderer/extensions/extension_helper.h	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/renderer/extensions/extension_helper.cc	View	4 chunks	+20 lines, -3 lines	0 comments	Download
A	chrome/renderer/weak_v8_function_map.h	View	1 chunk	+39 lines, -0 lines	0 comments	Download
A	chrome/renderer/weak_v8_function_map.cc	View	1 chunk	+51 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/8194005/1

9 years, 2 months ago (2011-10-07 03:22:35 UTC) #1

commit-bot: I haz the power

9 years, 2 months ago (2011-10-07 04:25:12 UTC) #2

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is linux_rel, revision is 104437, job name
was 8194005-1 (previous was lost) (previous was lost) (previous was lost)
(previous was lost).

Expand Messages | Collapse Messages