Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: views/bubble/bubble_delegate_unittest.cc

Issue 8194004: change the way windows are parented when their parent is set to NULL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/aura_shell/status_area_view.cc ('k') | views/bubble/bubble_frame_view_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/bubble/bubble_delegate_unittest.cc
===================================================================
--- views/bubble/bubble_delegate_unittest.cc (revision 104542)
+++ views/bubble/bubble_delegate_unittest.cc (working copy)
@@ -3,19 +3,21 @@
// found in the LICENSE file.
#include "base/memory/scoped_ptr.h"
-#include "base/message_loop.h"
#include "third_party/skia/include/core/SkColor.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/animation/slide_animation.h"
#include "views/bubble/bubble_border.h"
#include "views/bubble/bubble_delegate.h"
#include "views/bubble/bubble_view.h"
+#include "views/test/views_test_base.h"
#include "views/widget/widget.h"
namespace views {
namespace {
+typedef ViewsTestBase BubbleDelegateTest;
+
class TestBubbleDelegate : public BubbleDelegateView {
public:
explicit TestBubbleDelegate(Widget *frame): BubbleDelegateView(frame) {}
@@ -29,8 +31,7 @@
View view_;
};
-TEST(BubbleDelegateTest, CreateDelegate) {
- MessageLoopForUI message_loop;
+TEST_F(BubbleDelegateTest, CreateDelegate) {
scoped_ptr<Widget> bubble_widget(new Widget());
Widget::InitParams params(Widget::InitParams::TYPE_BUBBLE);
TestBubbleDelegate delegate(bubble_widget.get());
@@ -41,7 +42,7 @@
EXPECT_EQ(bubble_widget, delegate.GetWidget());
bubble_widget->CloseNow();
bubble_widget.reset(NULL);
- MessageLoop::current()->RunAllPending();
+ RunPendingMessages();
}
} // namespace
« no previous file with comments | « ui/aura_shell/status_area_view.cc ('k') | views/bubble/bubble_frame_view_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698