Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1240)

Issue 8194004: change the way windows are parented when their parent is set to NULL. (Closed)

Created:
9 years, 2 months ago by Ben Goodger (Google)
Modified:
9 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Changes the way windows are parented when their parent is set to NULL.. Adds a DesktopDelegate interface implemented by the aura client. The implementor handles parenting of windows when their parent is set to NULL, and also figures out how to activate windows.. Replaces Desktop::default_parent() with this. Requires adjusting some of the tests and adding a TestDesktopDelegate implementation that reconstructs what default_parent did.BUG=noneTEST=existing unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104558

Patch Set 1 : '' #

Total comments: 5

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+458 lines, -135 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
D chrome/browser/ui/views/aura/aura_init.h View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/browser/ui/views/aura/aura_init.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/aura/aura.gyp View 3 chunks +4 lines, -0 lines 0 comments Download
M ui/aura/desktop.h View 4 chunks +8 lines, -15 lines 0 comments Download
M ui/aura/desktop.cc View 6 chunks +4 lines, -25 lines 0 comments Download
A ui/aura/desktop_delegate.h View 1 chunk +29 lines, -0 lines 0 comments Download
M ui/aura/event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
A ui/aura/test_desktop_delegate.h View 1 chunk +38 lines, -0 lines 0 comments Download
A ui/aura/test_desktop_delegate.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M ui/aura/toplevel_window_container.h View 1 chunk +6 lines, -5 lines 0 comments Download
M ui/aura/toplevel_window_container.cc View 2 chunks +16 lines, -4 lines 0 comments Download
M ui/aura/window.h View 5 chunks +14 lines, -2 lines 0 comments Download
M ui/aura/window.cc View 7 chunks +28 lines, -5 lines 0 comments Download
A ui/aura/window_types.h View 1 chunk +20 lines, -0 lines 0 comments Download
M ui/aura/window_unittest.cc View 4 chunks +8 lines, -3 lines 0 comments Download
M ui/aura_shell/aura_shell.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/aura_shell/aura_shell_main.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/aura_shell/desktop_background_view.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/aura_shell/desktop_window.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ui/aura_shell/launcher/launcher_view.cc View 2 chunks +8 lines, -5 lines 0 comments Download
A ui/aura_shell/shell.h View 1 chunk +40 lines, -0 lines 0 comments Download
A ui/aura_shell/shell.cc View 1 chunk +116 lines, -0 lines 0 comments Download
M ui/aura_shell/shell_factory.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/aura_shell/shell_window_ids.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/aura_shell/status_area_view.cc View 2 chunks +4 lines, -1 line 0 comments Download
M views/bubble/bubble_delegate_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M views/bubble/bubble_frame_view_unittest.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M views/bubble/bubble_view_unittest.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M views/test/views_test_base.h View 2 chunks +7 lines, -0 lines 0 comments Download
M views/test/views_test_base.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M views/views.gyp View 2 chunks +7 lines, -0 lines 0 comments Download
M views/widget/native_widget_aura.cc View 4 chunks +29 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
9 years, 2 months ago (2011-10-07 18:01:30 UTC) #1
sky
9 years, 2 months ago (2011-10-07 19:59:45 UTC) #2
LGTM

http://codereview.chromium.org/8194004/diff/6046/ui/aura/test_desktop_delegat...
File ui/aura/test_desktop_delegate.cc (right):

http://codereview.chromium.org/8194004/diff/6046/ui/aura/test_desktop_delegat...
ui/aura/test_desktop_delegate.cc:13: Desktop::GetInstance()->set_delegate(this);
Unset in the destructor?

http://codereview.chromium.org/8194004/diff/6046/ui/aura/test_desktop_delegat...
ui/aura/test_desktop_delegate.cc:24: 
nit: remove one of these.

http://codereview.chromium.org/8194004/diff/6046/ui/aura/toplevel_window_cont...
File ui/aura/toplevel_window_container.h (right):

http://codereview.chromium.org/8194004/diff/6046/ui/aura/toplevel_window_cont...
ui/aura/toplevel_window_container.h:26: OVERRIDE;
nit: wrap function name to avoid dangling OVERRIDE.

http://codereview.chromium.org/8194004/diff/6046/ui/aura/window.h
File ui/aura/window.h (right):

http://codereview.chromium.org/8194004/diff/6046/ui/aura/window.h#newcode55
ui/aura/window.h:55: int type() const { return type_; }
Add a description of what this is and who uses it.

http://codereview.chromium.org/8194004/diff/6046/ui/aura_shell/shell.h
File ui/aura_shell/shell.h (right):

http://codereview.chromium.org/8194004/diff/6046/ui/aura_shell/shell.h#newcode19
ui/aura_shell/shell.h:19: class Shell : public aura::DesktopDelegate {
Add a description

Powered by Google App Engine
This is Rietveld 408576698