Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1372)

Unified Diff: chrome/installer/linux/debian/build.sh

Issue 81933002: Linux SxS: Use a non-colliding path for Debian packages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ${} Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/linux/debian/build.sh
diff --git a/chrome/installer/linux/debian/build.sh b/chrome/installer/linux/debian/build.sh
index 6c411206365fab097fd7bb3b76cd07243a564c47..645459064f2a5284146778cccbf5eca6d83f902b 100755
--- a/chrome/installer/linux/debian/build.sh
+++ b/chrome/installer/linux/debian/build.sh
@@ -63,14 +63,12 @@ stage_install_debian() {
local DEFAULT_FLAGS="--user-data-dir=\"${SXS_USER_DATA_DIR}\""
# Avoid file collisions between channels.
+ local INSTALLDIR="${INSTALLDIR}-${CHANNEL}"
+
# TODO(phajdan.jr): Do that for all packages for SxS,
# http://crbug.com/38598 .
- # We can't do this for now for all packages because of
- # http://crbug.com/295103 , and ultimately http://crbug.com/22703 .
- # Also see https://groups.google.com/a/chromium.org/d/msg/chromium-dev/DBEqOORaRiw/pE0bNI6h0kcJ .
if [ "$CHANNEL" = "trunk" ] || [ "$CHANNEL" = "asan" ]; then
local PACKAGE="${PACKAGE}-${CHANNEL}"
- local INSTALLDIR="${INSTALLDIR}-${CHANNEL}"
fi
# Make it possible to distinguish between menu entries
@@ -99,6 +97,24 @@ stage_install_debian() {
process_template "${BUILDDIR}/installer/debian/postrm" \
"${STAGEDIR}/DEBIAN/postrm"
chmod 755 "${STAGEDIR}/DEBIAN/postrm"
+
+ # Compatibility symlinks to avoid breaking Chrome on update.
+ # TODO(phajdan.jr): Remove before enabling SxS (obvious file collisions).
+ # See http://crbug.com/295103 , and ultimately http://crbug.com/22703 .
+ # Also see https://groups.google.com/a/chromium.org/d/msg/chromium-dev/DBEqOORaRiw/pE0bNI6h0kcJ .
+ if [ "${CHANNEL}" != "stable" ] && \
+ [ "${CHANNEL}" != "trunk" ] && \
+ [ "${CHANNEL}" != "asan" ]; then
+ mkdir -p "${STAGEDIR}/opt/google/chrome"
+ for x in chrome chrome-sandbox locales; do
+ ln -s "${INSTALLDIR}/${x}" "${STAGEDIR}/opt/google/chrome/${x}"
+ done
+ pushd "${STAGEDIR}/${INSTALLDIR}"
+ for x in *.pak; do
+ ln -s "${INSTALLDIR}/${x}" "${STAGEDIR}/opt/google/chrome/${x}"
+ done
+ popd
+ fi
}
# Actually generate the package file.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698