Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 81933002: Linux SxS: Use a non-colliding path for Debian packages. (Closed)

Created:
7 years, 1 month ago by Paweł Hajdan Jr.
Modified:
7 years, 1 month ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Linux SxS: Use a non-colliding path for Debian packages. This also adds compatibility symlinks so that running browsers continue to work (as a workaround for not everything going through the zygote). Next steps: same change for RPM, remove remaining collisions outside of /opt. BUG=38598 R=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236814

Patch Set 1 #

Total comments: 4

Patch Set 2 : ${} #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M chrome/installer/linux/debian/build.sh View 1 2 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Paweł Hajdan Jr.
7 years, 1 month ago (2013-11-21 23:24:03 UTC) #1
Lei Zhang
What about stable channel? Is it going into /opt/google/chrome-stable without symlinks? https://codereview.chromium.org/81933002/diff/1/chrome/installer/linux/debian/build.sh File chrome/installer/linux/debian/build.sh (right): ...
7 years, 1 month ago (2013-11-22 03:02:11 UTC) #2
Paweł Hajdan Jr.
PTAL https://codereview.chromium.org/81933002/diff/1/chrome/installer/linux/debian/build.sh File chrome/installer/linux/debian/build.sh (right): https://codereview.chromium.org/81933002/diff/1/chrome/installer/linux/debian/build.sh#newcode56 chrome/installer/linux/debian/build.sh:56: if [ "$CHANNEL" != "stable" ]; then We ...
7 years, 1 month ago (2013-11-22 17:55:46 UTC) #3
Lei Zhang
lgtm https://codereview.chromium.org/81933002/diff/1/chrome/installer/linux/debian/build.sh File chrome/installer/linux/debian/build.sh (right): https://codereview.chromium.org/81933002/diff/1/chrome/installer/linux/debian/build.sh#newcode56 chrome/installer/linux/debian/build.sh:56: if [ "$CHANNEL" != "stable" ]; then On ...
7 years, 1 month ago (2013-11-22 19:48:45 UTC) #4
Paweł Hajdan Jr.
7 years, 1 month ago (2013-11-22 20:03:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r236814 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698