Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 819293002: Set whether context menu appears on mouse up from WebPreferences (Closed)

Created:
6 years ago by Arjan van Leeuwen
Modified:
5 years, 9 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set whether context menu appears on mouse up from WebPreferences Whether the context menu appears on mouse up can depend on run-time settings (in the case of Opera). This reads the setting to WebPreferences, so that the browser has the possibility of communicating the appropriate setting to the renderer. If not explicitly set, it defaults, as before, to 'true' on Windows and 'false' on other platforms. BUG= Committed: https://crrev.com/9880491900bb5568e0ec7d152f914ce20f875462 Cr-Commit-Position: refs/heads/master@{#319040}

Patch Set 1 #

Patch Set 2 : Fix merge issue in earlier patch #

Total comments: 1

Patch Set 3 : Fix order to be like WebPreferences #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M content/public/common/common_param_traits_macros.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/web_preferences.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/web_preferences.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 24 (10 generated)
Arjan van Leeuwen
This small patch shouldn't affect Chrome, but makes some features in Opera easier to implement ...
6 years ago (2014-12-23 13:35:00 UTC) #2
Arjan van Leeuwen
Adding some more reviewers.
5 years, 10 months ago (2015-02-23 07:34:44 UTC) #4
Avi (use Gerrit)
lgtm If it helps you guys, sure.
5 years, 10 months ago (2015-02-23 16:38:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/819293002/1
5 years, 10 months ago (2015-02-23 16:41:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61678)
5 years, 10 months ago (2015-02-23 16:44:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/819293002/20001
5 years, 10 months ago (2015-02-24 08:00:51 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/44997)
5 years, 10 months ago (2015-02-24 08:19:34 UTC) #14
Arjan van Leeuwen
Looks like I also need an LGTM from +tsepez or +nasko for the change in ...
5 years, 10 months ago (2015-02-24 08:28:56 UTC) #16
nasko
LGTM, assuming the change in common_param_traits_macros.h is made. https://codereview.chromium.org/819293002/diff/20001/content/public/common/common_param_traits_macros.h File content/public/common/common_param_traits_macros.h (right): https://codereview.chromium.org/819293002/diff/20001/content/public/common/common_param_traits_macros.h#newcode113 content/public/common/common_param_traits_macros.h:113: IPC_STRUCT_TRAITS_MEMBER(context_menu_on_mouse_up) ...
5 years, 10 months ago (2015-02-24 16:26:03 UTC) #17
Tom Sepez
LGTM, deferring to nasko.
5 years, 10 months ago (2015-02-25 17:46:57 UTC) #18
Arjan van Leeuwen
Now with order changed as requested.
5 years, 9 months ago (2015-03-02 10:09:54 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/819293002/40001
5 years, 9 months ago (2015-03-04 08:22:25 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-04 09:23:13 UTC) #23
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 09:23:45 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9880491900bb5568e0ec7d152f914ce20f875462
Cr-Commit-Position: refs/heads/master@{#319040}

Powered by Google App Engine
This is Rietveld 408576698